[https://nvbugs/6541322][fix] Unwaive fixed test - #17131
Conversation
WalkthroughThe integration test waiver for Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/unittest/_torch/executor/test_mamba_cache_manager.py`:
- Around line 1311-1313: Update
test_v2_hybrid_default_preserves_live_state_slot_floor by annotating
num_reserved_dummy_slots and expected_num_slots as int and the function return
type as None.
- Around line 1305-1355: Add test-list entries for
test_v2_hybrid_default_preserves_live_state_slot_floor and
test_v2_hybrid_typical_batch_splits_capacity_across_ssm_states_and_dummies in
the appropriate test-db and/or qa list under tests/integration/test_lists.
Ensure both newly covered tests are registered using the existing list format.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e356549f-f013-4718-bfec-95dd8b5af9ad
📒 Files selected for processing (3)
tensorrt_llm/_torch/pyexecutor/mamba_cache_manager.pytests/integration/test_lists/waives.txttests/unittest/_torch/executor/test_mamba_cache_manager.py
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/waives.txt
5337896 to
cd5b4e4
Compare
|
/bot run |
|
PR_Github #63091 [ run ] triggered by Bot. Commit: |
|
PR_Github #63091 [ run ] completed with state |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
BowenFu
left a comment
There was a problem hiding this comment.
Root cause checks out: a1e5771 dropped the default warmup constraints when `avg_seq_len` is unset, and 7f7dccf restores an explicit floor (`mamba_cache_manager.py`, `ssm_floor_slots = _max_resident_sequences() + _num_reserved_dummy_slots`) — that is the invariant that was missing, not a workaround.
Two notes, neither blocking:
- This test is post-merge-only (`l0_dgx_h200.yml:42`, `l0_gb200_multi_gpus.yml:86`), so the green `/bot run` here did not execute it. What covers the gap is your verification on main plus the repair-bot run on HEAD recorded in nvbugs/6541322.
- #17150 removes the identical line. Worth closing one of the two before either lands.
Dev Engineer Review
avg_seq_lenis unset.QA Engineer Review
tests/integration/test_lists/waives.txt.accuracy/test_llm_api_pytorch.py::TestQwen3NextInstruct::test_bf16_4gpu[dep4].Verdict: needs follow-up
Description
Commit 7f7dccf added an explicit SSM min-slot floor which fixes the
regression introduced by a1e5771.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.