[https://nvbugs/6550708][fix] Stub _profiler=VisualGenProfiler() in the double (matching the sibling… - #17204
Closed
trtllm-agent wants to merge 1 commit into
Closed
[https://nvbugs/6550708][fix] Stub _profiler=VisualGenProfiler() in the double (matching the sibling…#17204trtllm-agent wants to merge 1 commit into
_profiler=VisualGenProfiler() in the double (matching the sibling…#17204trtllm-agent wants to merge 1 commit into
Conversation
The VisualGen profiler refactor moved the denoise loop's window state onto a VisualGenProfiler held as BasePipeline._profiler, which the shared denoise() loop now dereferences unconditionally. The Cosmos3 test double builds its pipeline via object.__new__, skipping __init__, so _profiler was never created and all four denoise-loop tests raised AttributeError. Stub the profiler the same way the sibling Qwen-Image double already does, and drop the three attributes that refactor orphaned (_profile_range, _predenoise_pending, _postdenoise_pending) -- those now live on the profiler and nothing reads them off the pipeline. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe Cosmos3 distilled test fixture now supplies ChangesCosmos3 profiler fixture
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
1 task
Collaborator
|
closing PR as the change has been merged in ac534c6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self._profiler, assigned only inBasePipeline.__init__, but the Cosmos3 test double builds its pipeline viaobject.__new__and so never gets one._profiler=VisualGenProfiler()in the double (matching the sibling Qwen-Image helper the same commit fixed) and drop the three orphaned attrs; unscoped the profiler is a no-op, so iteration semantics are unchanged.Test plan
Links
Dev Engineer Review
VisualGenProfilerto the Cosmos3 denoise test double._profilerAttributeErrorfailures.QA Engineer Review
_denoise_ready_pipeline().