[https://nvbugs/6550708][fix] initialize profiler in Cosmos3 test fixture - #17212
Conversation
Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe Cosmos3 distilled visual generation test now imports ChangesCosmos3 profiler setup
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #63466 [ run ] triggered by Bot. Commit: |
|
PR_Github #63466 [ run ] completed with state |
Dev Engineer Review
tests/unittest/_torch/visual_gen/test_cosmos3_distilled.py._denoise_ready_pipelinewithVisualGenProfiler.BasePipelinecontract and the equivalent Qwen fixture.QA Engineer Review
_profilerdependency.tests/integration/test_lists/coverage entry was changed.Description
Fixes NVBug 6550708, which causes four Cosmos3 distilled denoise unit tests to fail after the VisualGen profiler refactor.
The test fixture constructs
Cosmos3OmniMoTPipelinewithobject.__new__, bypassingBasePipeline.__init__. It still initialized the removed_predenoise_pending,_postdenoise_pending, and_profile_rangefields, while the denoise path now expects_profilerto exist.Initialize the fixture with
VisualGenProfiler, matching the current pipeline contract and the equivalent Qwen test fixture. This is a test-only change and does not affect runtime behavior.Test Coverage
python3 -m pytest -q tests/unittest/_torch/visual_gen/test_cosmos3_distilled.py87 passed, 3 warnings in 1.88sPR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.