Skip to content

[https://nvbugs/6550708][fix] initialize profiler in Cosmos3 test fixture - #17212

Merged
achartier merged 1 commit into
NVIDIA:mainfrom
achartier:fix-cosmos3-distilled-profiler
Aug 3, 2026
Merged

[https://nvbugs/6550708][fix] initialize profiler in Cosmos3 test fixture#17212
achartier merged 1 commit into
NVIDIA:mainfrom
achartier:fix-cosmos3-distilled-profiler

Conversation

@achartier

@achartier achartier commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Updated tests/unittest/_torch/visual_gen/test_cosmos3_distilled.py.
  • Initialized _denoise_ready_pipeline with VisualGenProfiler.
  • Removed obsolete profiler state fields.
  • The fixture now matches the current BasePipeline contract and the equivalent Qwen fixture.
  • The change is test-only and has low regression risk.
  • No public entities, configuration files, or test-list files changed.

QA Engineer Review

  • Modified the Cosmos3 distilled denoise test fixture.
  • No test functions were added, modified, or removed.
  • The existing four Cosmos3 denoise unit tests now receive the required _profiler dependency.
  • No tests/integration/test_lists/ coverage entry was changed.
  • Validation reported 87 tests passing.
  • Verdict: sufficient.

Description

Fixes NVBug 6550708, which causes four Cosmos3 distilled denoise unit tests to fail after the VisualGen profiler refactor.

The test fixture constructs Cosmos3OmniMoTPipeline with object.__new__, bypassing BasePipeline.__init__. It still initialized the removed _predenoise_pending, _postdenoise_pending, and _profile_range fields, while the denoise path now expects _profiler to exist.

Initialize the fixture with VisualGenProfiler, matching the current pipeline contract and the equivalent Qwen test fixture. This is a test-only change and does not affect runtime behavior.

Test Coverage

  • H100, tekit container:
    • python3 -m pytest -q tests/unittest/_torch/visual_gen/test_cosmos3_distilled.py
    • 87 passed, 3 warnings in 1.88s

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
@achartier
achartier marked this pull request as ready for review August 3, 2026 14:49
@achartier
achartier requested a review from a team as a code owner August 3, 2026 14:49
@achartier

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d30c6cb0-fe33-4e62-bb9a-702a94497557

📥 Commits

Reviewing files that changed from the base of the PR and between c5427c5 and 9339d04.

📒 Files selected for processing (1)
  • tests/unittest/_torch/visual_gen/test_cosmos3_distilled.py

Walkthrough

The Cosmos3 distilled visual generation test now imports VisualGenProfiler and initializes the denoise-ready pipeline with a profiler. The fixture no longer defines the legacy denoise profiling state fields.

Changes

Cosmos3 profiler setup

Layer / File(s) Summary
Update denoise pipeline profiling setup
tests/unittest/_torch/visual_gen/test_cosmos3_distilled.py
The test imports VisualGenProfiler, initializes _profiler, and removes the legacy denoise profiling fields.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#17204: Modifies _denoise_ready_pipeline and the same profiler-related fields in test_cosmos3_distilled.py.

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required NVBugs and type format and clearly describes the profiler initialization fix.
Description check ✅ Passed The description explains the issue and solution, identifies the test coverage, and includes the repository checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63466 [ run ] triggered by Bot. Commit: 9339d04 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63466 [ run ] completed with state SUCCESS. Commit: 9339d04
/LLM/main/L0_MergeRequest_PR pipeline #51437 completed with status: 'SUCCESS'

CI Report

Link to invocation

@achartier
achartier merged commit ac534c6 into NVIDIA:main Aug 3, 2026
13 checks passed
@achartier
achartier deleted the fix-cosmos3-distilled-profiler branch August 3, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants