Skip to content

[https://nvbugs/6550708][infra] Re-enable Cosmos3 distilled tests - #17214

Merged
achartier merged 1 commit into
NVIDIA:mainfrom
achartier:reenable-cosmos3-distilled-tests
Aug 3, 2026
Merged

[https://nvbugs/6550708][infra] Re-enable Cosmos3 distilled tests#17214
achartier merged 1 commit into
NVIDIA:mainfrom
achartier:reenable-cosmos3-distilled-tests

Conversation

@achartier

@achartier achartier commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed four Cosmos3 distilled test entries from tests/integration/test_lists/waives.txt.
  • The change restores test execution after the related fixture fix merged in PR #17212.
  • The waiver file remains correctly formatted.
  • Duplicate-waiver and test-list validation passed.
  • The change is limited to the intended DGX B200 PyTorch stage scope.

QA Engineer Review

  • No test-db/ or qa/ files were modified.
  • Four existing waived tests were removed from waives.txt.
  • Stage mapping validation passed.
  • Fixture testing passed with 87 tests and 3 warnings.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Description

Re-enables the four Cosmos3 distilled denoise tests waived for NVBug 6550708 by commit 7b50104221dfe13f6820952e898713d9d19db2fe while the failure was being fixed.

The fixture fix has now merged in TensorRT-LLM #17212. Remove the corresponding entries from waives.txt so the tests run again in the DGX B200 PyTorch stages.

Test Coverage

  • python3 scripts/check_test_list.py --check-duplicate-waives
  • python3 scripts/check_test_list.py --validate
    • OK: 2116 unique test entries validated.
  • python3 scripts/test_to_stage_mapping.py --tests unittest/_torch/visual_gen/test_cosmos3_distilled.py
    • Confirmed mapping to DGX_B200-PyTorch-1 through DGX_B200-PyTorch-9.
  • The fixture fix in [https://nvbugs/6550708][fix] initialize profiler in Cosmos3 test fixture #17212 was validated in the tekit container on H100: 87 passed, 3 warnings.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
@achartier
achartier marked this pull request as ready for review August 3, 2026 16:04
@achartier
achartier requested review from a team as code owners August 3, 2026 16:04
@achartier

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 469eb699-dada-423e-a4e5-0958171d49e9

📥 Commits

Reviewing files that changed from the base of the PR and between ac534c6 and 5438e45.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

The change removes four Cosmos3 distilled visual-generation test entries from the integration waiver list.

Changes

Cosmos3 waiver cleanup

Layer / File(s) Summary
Remove obsolete Cosmos3 waivers
tests/integration/test_lists/waives.txt
Removed waivers for four Cosmos3 distilled conditioning and denoise-loop tests.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: jieli-matrix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required ticket and type format and clearly states that the Cosmos3 distilled tests are re-enabled.
Description check ✅ Passed The description explains the change, reason, affected stages, validation steps, and checklist status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63489 [ run ] triggered by Bot. Commit: 5438e45 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63489 [ run ] completed with state SUCCESS. Commit: 5438e45
/LLM/main/L0_MergeRequest_PR pipeline #51458 completed with status: 'SUCCESS'

CI Report

Link to invocation

@achartier
achartier merged commit 6245215 into NVIDIA:main Aug 3, 2026
13 checks passed
@achartier
achartier deleted the reenable-cosmos3-distilled-tests branch August 3, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants