Skip to content

[https://nvbugs/6426847][fix] Unwaive DeepSeekV3Lite MTP test - #17217

Open
cascade812 wants to merge 1 commit into
NVIDIA:mainfrom
cascade812:guiju/unwaive2
Open

[https://nvbugs/6426847][fix] Unwaive DeepSeekV3Lite MTP test#17217
cascade812 wants to merge 1 commit into
NVIDIA:mainfrom
cascade812:guiju/unwaive2

Conversation

@cascade812

@cascade812 cascade812 commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed the waiver for the DeepSeekV3Lite bfloat16 MTP test configuration.
  • The change is limited to one waives.txt entry.
  • The waiver file remains correctly formatted.
  • No public API, performance, or error-handling changes are included.
  • No duplicate or unintended scope changes were identified.

QA Engineer Review

  • Modified test-list file: tests/integration/test_lists/waives.txt.
  • Removed the DeepSeekV3Lite bfloat16 test waiver for MTP nextn=2, attention DP, CUDA graphs, overlap scheduling, and V2 KV cache.
  • No test-db/ or qa/ files were modified.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Guiju Zhang <7135567+cascade812@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d18d23a7-58b6-4221-9960-b74709558334

📥 Commits

Reviewing files that changed from the base of the PR and between 6245215 and 1df2d5b.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

Removed the skip waiver for the DeepSeekV3Lite bfloat16 test with MTP nextn=2, attention DP, CUDA graphs, overlap scheduling, and V2 KV cache.

Changes

Cohort / File(s) Summary
Integration test waiver update
tests/integration/test_lists/waives.txt
Removed the waiver for the specified DeepSeekV3Lite test configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: brnguyen2, schetlur-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description leaves the required Description and Test Coverage sections empty, so it does not explain the change or identify relevant tests. Add a concise issue and solution summary, and list the relevant test or validation that confirms the waiver removal.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required NVBugs and type format and clearly identifies the unwaived DeepSeekV3Lite MTP test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@cascade812

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_H100-PyTorch-Post-Merge-1, DGX_H100-PyTorch-Post-Merge-2"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63538 [ run ] triggered by Bot. Commit: 1df2d5b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63538 [ run ] completed with state SUCCESS. Commit: 1df2d5b
/LLM/main/L0_MergeRequest_PR pipeline #51504 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants