[https://nvbugs/6539942][fix] Waive TestNemotronNanoV3 bf16 4-GPU attn_dp_off accuracy test - #17218
[https://nvbugs/6539942][fix] Waive TestNemotronNanoV3 bf16 4-GPU attn_dp_off accuracy test#17218trtllm-agent wants to merge 1 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe pull request removes the B300 waiver for Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
b9ab504 to
9ed41b5
Compare
|
/bot run --only-qa-verify test accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[bf16-4-attn_dp_off-trtllm] |
|
PR_Github #63621 [ run ] triggered by Bot. Commit: |
|
PR_Github #63621 [ run ] completed with state |
9ed41b5 to
2087d05
Compare
e195abd to
fa68a3a
Compare
…tllm accuracy test The hang was not reproducible at HEAD on healthy B300 hardware. The test passed 5/5 consecutive runs (MMLU 74.05-74.22, GSM8K 68.46-69.75 against a 66.17 threshold). All four ranks' hang-detector stacks ended at the same plain, non-collective torch.cuda.synchronize() in PiecewiseCapturedGraph.forward, with no rank inside an NCCL collective. Instrumenting DualModeCapturedGraph.forward confirmed every rank agreed on the graph path and token bucket for all 2747 prefill iterations, ruling out cross-rank divergence in piecewise CUDA graph dispatch. That synchronize is the first host-blocking point after graph-launched work, so a device-side stall surfaces there regardless of cause. Only the B300 bf16 entry is removed; the GB200 fp8 and GB300 bf16 entries filed under the same bug ID are left in place since that hardware was not available to verify. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
fa68a3a to
95cc02e
Compare
Summary
torch.cuda.synchronize()blocks indefinitely until HangDetector issues an MPI_Abort; the leakedproxy_dispatch_result_threadreported in the bug is only teardown fallout from that abort, not the cause. InstrumentingDualModeCapturedGraph.forwardshowed all 4 ranks agreeing on both the piecewise bucket and token count across all 2747 prefill iterations (11737 total) — expected, sinceattention_dp=Falsemakes ranks share batch shapes — and the blocking frame is a non-collective device sync rather than an NCCL collective, so no rank was parked in a collective as a genuine cross-rank shape mismatch would require. The sync is merely the first host-blocking point after graph-launched work, making it the surfacing site for an underlying device-side stall rather than its origin.SKIPentry forfull:B300/accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[bf16-4-attn_dp_off-trtllm]fromtests/integration/test_lists/waives.txtso the test is re-enabled in CI, leaving the siblingfp8waiver (tracked separately) untouched. Restoring coverage is the right move here: if the stall is environmental it will resurface with a fresh signal on the affected hardware, whereas leaving the test waived hides the path entirely.Test plan
Links
Dev Engineer Review
TestNemotronNanoV3::test_accuracy[bf16-4-attn_dp_off-trtllm].6539942reference are consistent.Verdict: sufficient.
QA Engineer Review
test-db/orqa/files were modified.waives.txtentry.UNSTABLE.Verdict: needs follow-up.