[https://nvbugs/6428096][fix] Unwaive DeepSeekV3Lite compiled tp2pp2 - #17375
[https://nvbugs/6428096][fix] Unwaive DeepSeekV3Lite compiled tp2pp2#17375cascade812 wants to merge 1 commit into
Conversation
…test Signed-off-by: Guiju Zhang <7135567+cascade812@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe change removes one skip configuration from the integration test waiver list. The affected test uses DeepSeekV3Lite BF16 on four GPUs with ChangesDeepSeekV3Lite waiver removal
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --stage-list "DGX_H200-4_GPUs-PyTorch-Post-Merge-1" |
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
Removal looks justified — the tracked failure and the follow-on issue found while investigating it are both resolved on main.
One thing before merge: this parametrization only appears in post_merge blocks (l0_gb200_multi_gpus.yml:111, l0_dgx_b300.yml:37, l0_rtx_pro_6000.yml:76), so a plain /bot run won't exercise it and the unwaive ships unvalidated. Please run the stage explicitly, e.g. /bot run --extra-stage "GB200-4_GPUs-PyTorch-Post-Merge-1", and link the result. The test was flagged flaky historically, so one green run is the minimum evidence.
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #64415 [ run ] triggered by Bot. Commit: |
|
PR_Github #64415 [ run ] completed with state
|
…test
Dev Engineer Review
DeepSeekV3Litetp2pp2BF16 4-GPU test withtorch_compile=Trueand CUDA graphs disabled.tests/integration/test_lists/waives.txtand does not alter public entities.QA Engineer Review
test-db/orqa/files were modified.tests/integration/test_lists/waives.txt.tp2pp2configuration.Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.