feat: Add NIXL support - #3677
Closed
Shixiaowei02 wants to merge 13 commits into
Closed
Conversation
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Collaborator
|
Thanks @Shixiaowei02 for preparing this MR. Thanks for the hard work from NIXL folks! It is great to see this NIXL integration MR coming in, let's prioritize the review of this MR. @chuangz0 . June |
ebarilanM
reviewed
Apr 20, 2025
| : mCacheManager{cacheManager} | ||
| { | ||
| TLLM_CHECK(mCacheManager); | ||
|
|
There was a problem hiding this comment.
why not have a single pool? most of the time worker will be or sender or receiver
|
|
||
| DataSenderImpl::DataSenderImpl(executor::kv_cache::ConnectionManager* manager, | ||
| executor::kv_cache::CacheState selfCacheState, SizeType32 selfIndex, std::unique_ptr<IOFormatter> formatter) | ||
| executor::kv_cache::ConnectionManager* nixlManager, executor::kv_cache::CacheState selfCacheState, |
There was a problem hiding this comment.
have both mManager and mNixlManager is temp? do we plan remove it when support new commState?
Collaborator
There was a problem hiding this comment.
Right, this is only temp, we will use only mManager (which will be MPI/UCX/NIXL)
Closed
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Collaborator
|
@Shixiaowei02 @zackyoray is this PR still relevant? If not, can we close? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.