Nixl infra - #3769
Conversation
There was a problem hiding this comment.
Is this the /opt/nvidia/nvda_nixl directory? I think it needs to be modified because the development docker image does not have write permissions for this directory by default.
There was a problem hiding this comment.
its not running inside /opt/nvidia/nvda_nixl (it is running inside the cpp/build/nixl_build)
but it will install into /opt/nvidia/nvda_nixl
There was a problem hiding this comment.
We need a more general method to locate UCX, as the path in our default development Docker image is not /usr/local/ucx.
There was a problem hiding this comment.
Do you have any suggested method? using ENV var? CMAK var?
I added for now cmake -DUCX_PATH=/your/custom/ucx/path
Co-authored-by: Rabia Loulou <174243936+rabial-nv@users.noreply.github.com> Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
dbf17c7 to
0185e5f
Compare
Tests for the NIXL can be found in the nixl_build directory:
- `{build_dir}/nixl_build/test/nixl/agent_example`
- `{build_dir}/nixl_build/test/nixl/nixl_test`
Co-authored-by: Rabia Loulou <174243936+rabial-nv@users.noreply.github.com>
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Co-authored-by: Rabia Loulou <174243936+rabial-nv@users.noreply.github.com> Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Add temp nixl code for testing compilation Co-authored-by: Rabia Loulou <174243936+rabial-nv@users.noreply.github.com> Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
|
/bot run |
|
PR_Github #3301 [ run ] triggered by Bot |
|
PR_Github #3301 [ run ] completed with state |
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
|
/bot run |
|
PR_Github #3304 [ run ] triggered by Bot |
|
PR_Github #3304 [ run ] completed with state |
| # Find NIXL | ||
| find_path(NIXL_INCLUDE_DIR nixl.h HINTS ${NIXL_ROOT}/include) | ||
|
|
||
| # Find all required NIXL libraries |
There was a problem hiding this comment.
Here and the script above are repeated, can we simply use find_package?
There was a problem hiding this comment.
sure. will add commit that add find_package. if you prefer i can squash it into the existing one.
| if(NOT WIN32) | ||
| set_target_properties( | ||
| ${BATCH_MANAGER_STATIC_TARGET} | ||
| PROPERTIES BUILD_RPATH "/opt/nvidia/nvda_nixl/lib/x86_64-linux-gnu" |
There was a problem hiding this comment.
This still uses the absolute path /opt.
|
/bot run --disable-fail-fast |
|
PR_Github #3494 [ run ] triggered by Bot |
|
PR_Github #3494 [ run ] completed with state |
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
/bot run --disable-fail-fast |
|
PR_Github #3619 [ run ] triggered by Bot |
|
PR_Github #3606 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #3633 [ run ] triggered by Bot |
|
PR_Github #3619 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #3635 [ run ] triggered by Bot |
|
PR_Github #3633 [ run ] completed with state |
bd7a7d4 to
e9d2df7
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #3639 [ run ] triggered by Bot |
|
PR_Github #3635 [ run ] completed with state |
|
PR_Github #3639 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #3728 [ run ] triggered by Bot |
Signed-off-by: Yoray Zack <62789610+zackyoray@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #3731 [ run ] triggered by Bot |
|
PR_Github #3728 [ run ] completed with state |
|
PR_Github #3731 [ run ] completed with state |
|
Is this PR still relevant? @zackyoray @Shixiaowei02 ? If not, can we close? Thx. |
4 participants
Add nixl infrastructure to trtllm
[Split from https://github.com//pull/3677]