Skip to content

58558916 improve run manager opening speed#673

Merged
elainethale merged 6 commits into
developfrom
58558916-ImproveRunManagerOpeningSpeed
Dec 6, 2013
Merged

58558916 improve run manager opening speed#673
elainethale merged 6 commits into
developfrom
58558916-ImproveRunManagerOpeningSpeed

Conversation

@lefticus

Copy link
Copy Markdown
Contributor

Opening Pat:

Linux RelWithDebInfo, BigPatTest (50% complete):

Before Changes: 20s
After Changes: 10s

Windows Release Build, BigPatTest (50% complete):

Before Changes: 30.1 s
After Changes: 21.9 s

RelWithDebInfo on Linux:

Loading a completed BigPat Test:

Before changes: 20s
After reliminating UI components: 15s
After reducing debug output: 10s
@ghost ghost assigned elainethale Nov 23, 2013
@lefticus

lefticus commented Dec 4, 2013

Copy link
Copy Markdown
Contributor Author

@elainethale I'd like you to evaluate this again. If it is still not fast enough, please quantify what you are seeing. On my system, windows (Release build) with a fully completed BigPatTest load:

Before my changes: 65s
After my changes: 29s

I'm hitting the wall to the point that I've begun parallelizing the parsing of the database data to the extent that I can.

Please compare on your system develop vs this branch so I can verify if I've managed any performance improvement on your system. To make the process less painful, I've just updated my branch to the latest develop head.

Also, I know that a lot of signals are processed. If you are using AQTime exclusively, I'd be suspicious that its signal tracking is interfering with the performance timing. For the sake of Windows testing, I've been simply using a stopwatch.

@elainethale

Copy link
Copy Markdown
Member

@lefticus Thanks, Jason--I'm on it!

@elainethale

Copy link
Copy Markdown
Member

I see 30% improvement when clocking PAT by hand or timing openPATProject in Ruby. (AQTime does not show the improvement.) Double-checking some unit tests. Assuming those are okay, will merge in the morning.

@lefticus

lefticus commented Dec 6, 2013

Copy link
Copy Markdown
Contributor Author

Sounds good. I know that a fair number of signals are fired while building the job tree, but using something like valgrind those don't show up in the performance metrics at all. I bet we could get a performance increase from AQTime's perspective by disabling signals during loading, but that would be tuning just to the one tool and probably not show any real world difference.

elainethale added a commit that referenced this pull request Dec 6, 2013
@elainethale
elainethale merged commit 5eddb05 into develop Dec 6, 2013
@elainethale
elainethale deleted the 58558916-ImproveRunManagerOpeningSpeed branch December 6, 2013 15:59
jmarrec added a commit that referenced this pull request Jun 29, 2026
…ot too much

```diff
-1/5 Test #673: BCLFixture.RemoteBCLTest ...............   Passed   24.32 sec
+1/5 Test #673: BCLFixture.RemoteBCLTest ...............   Passed   26.52 sec
-2/5 Test #674: BCLFixture.RemoteBCLTest2 ..............   Passed    4.15 sec
+2/5 Test #674: BCLFixture.RemoteBCLTest2 ..............   Passed    3.43 sec
-3/5 Test #676: BCLFixture.RemoteBCLMetaSearchTest .....   Passed    4.04 sec
+3/5 Test #676: BCLFixture.RemoteBCLMetaSearchTest .....   Passed    4.97 sec
-4/5 Test #677: BCLFixture.RemoteBCL_EncodingURI .......   Passed    4.90 sec
+4/5 Test #677: BCLFixture.RemoteBCL_EncodingURI .......   Passed    5.09 sec
-5/5 Test #678: BCLFixture.RemoteBCL_BCLSearchResult ...   Passed    3.88 sec
+5/5 Test #678: BCLFixture.RemoteBCL_BCLSearchResult ...   Passed    5.25 sec
```
jmarrec added a commit that referenced this pull request Jul 16, 2026
…ot too much

```diff
-1/5 Test #673: BCLFixture.RemoteBCLTest ...............   Passed   24.32 sec
+1/5 Test #673: BCLFixture.RemoteBCLTest ...............   Passed   26.52 sec
-2/5 Test #674: BCLFixture.RemoteBCLTest2 ..............   Passed    4.15 sec
+2/5 Test #674: BCLFixture.RemoteBCLTest2 ..............   Passed    3.43 sec
-3/5 Test #676: BCLFixture.RemoteBCLMetaSearchTest .....   Passed    4.04 sec
+3/5 Test #676: BCLFixture.RemoteBCLMetaSearchTest .....   Passed    4.97 sec
-4/5 Test #677: BCLFixture.RemoteBCL_EncodingURI .......   Passed    4.90 sec
+4/5 Test #677: BCLFixture.RemoteBCL_EncodingURI .......   Passed    5.09 sec
-5/5 Test #678: BCLFixture.RemoteBCL_BCLSearchResult ...   Passed    3.88 sec
+5/5 Test #678: BCLFixture.RemoteBCL_BCLSearchResult ...   Passed    5.25 sec
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants