43144741 contam translator#674
Merged
macumber merged 5 commits intoNov 25, 2013
Merged
Conversation
Contributor
There was a problem hiding this comment.
@jasondegraw Any reason you would need this public? Can't it just be called on translateModel?
Member
Author
There was a problem hiding this comment.
@macumber I'd like to keep this one public. There are a couple of use cases where someone might want to do some different things with the file. Since we're only allowed one CVF per model, there isn't a lot of flexibility there.
jmarrec
added a commit
that referenced
this pull request
Jun 29, 2026
…ot too much ```diff -1/5 Test #673: BCLFixture.RemoteBCLTest ............... Passed 24.32 sec +1/5 Test #673: BCLFixture.RemoteBCLTest ............... Passed 26.52 sec -2/5 Test #674: BCLFixture.RemoteBCLTest2 .............. Passed 4.15 sec +2/5 Test #674: BCLFixture.RemoteBCLTest2 .............. Passed 3.43 sec -3/5 Test #676: BCLFixture.RemoteBCLMetaSearchTest ..... Passed 4.04 sec +3/5 Test #676: BCLFixture.RemoteBCLMetaSearchTest ..... Passed 4.97 sec -4/5 Test #677: BCLFixture.RemoteBCL_EncodingURI ....... Passed 4.90 sec +4/5 Test #677: BCLFixture.RemoteBCL_EncodingURI ....... Passed 5.09 sec -5/5 Test #678: BCLFixture.RemoteBCL_BCLSearchResult ... Passed 3.88 sec +5/5 Test #678: BCLFixture.RemoteBCL_BCLSearchResult ... Passed 5.25 sec ```
jmarrec
added a commit
that referenced
this pull request
Jul 16, 2026
…ot too much ```diff -1/5 Test #673: BCLFixture.RemoteBCLTest ............... Passed 24.32 sec +1/5 Test #673: BCLFixture.RemoteBCLTest ............... Passed 26.52 sec -2/5 Test #674: BCLFixture.RemoteBCLTest2 .............. Passed 4.15 sec +2/5 Test #674: BCLFixture.RemoteBCLTest2 .............. Passed 3.43 sec -3/5 Test #676: BCLFixture.RemoteBCLMetaSearchTest ..... Passed 4.04 sec +3/5 Test #676: BCLFixture.RemoteBCLMetaSearchTest ..... Passed 4.97 sec -4/5 Test #677: BCLFixture.RemoteBCL_EncodingURI ....... Passed 4.90 sec +4/5 Test #677: BCLFixture.RemoteBCL_EncodingURI ....... Passed 5.09 sec -5/5 Test #678: BCLFixture.RemoteBCL_BCLSearchResult ... Passed 3.88 sec +5/5 Test #678: BCLFixture.RemoteBCL_BCLSearchResult ... Passed 5.25 sec ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@macumber These changes address most of the things that we've discussed, particularly the translator and model objects. I have implemented a lazy read of the EPW data, but I am somewhat unsatisfied with it. I'm not sure that the data vector is really the thing to look at to determine if a read should be attempted. I also added an additional test to try out various things with it, and that seems to work as expected.