Update logic to ensure TTY mode is appropriately disabled#162
Merged
SRWieZ merged 4 commits intoFeb 17, 2025
Conversation
added 4 commits
February 5, 2025 13:22
Fixes https://github.com/NativePHP/laravel/issues/468 - Utilises the Symfony Process class which has a tried and tested `isTtySupported()` method. This will return false if windows due to a DIRECTORY_SEPARATOR check. - Removed check for Windows specifically as this is checked as above. - Ensures even if TTY is supported, it is still set to off when -n|--non-interactive is specified.
PeteBishwhip
force-pushed
the
bugfix/468-tty-support-checks
branch
2 times, most recently
from
ac7324b to
ebc5dca
Compare
Member
Author
|
Half of the tests are now working with my slight changes. The fails were relating to GH Actions and how it was specifying specific versions that appeared to already be implied as good. I just was more specific. I have no idea what is going on in Ubuntu with being unable to boot right now. I know that wasn't related to this change. |
SRWieZ
reviewed
Feb 13, 2025
SRWieZ
approved these changes
Feb 13, 2025
gwleuverink
approved these changes
Feb 16, 2025
Member
|
If @gwleuverink approves it, we can merge it. Next, we need to merge Willem's work before making any other changes to the build command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/NativePHP/laravel/issues/468
isTtySupported()method. This will return false if windows due to a DIRECTORY_SEPARATOR check.Supporting Documentation:
https://symfony.com/doc/current/components/process.html#checking-for-tty-support