Skip to content

Update logic to ensure TTY mode is appropriately disabled #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SRWieZ merged 4 commits into from
Feb 17, 2025
Merged

Update logic to ensure TTY mode is appropriately disabled #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cc41a7
Update logic to ensure TTY mode is appropriately disabled
Feb 5, 2025
b6c5a2f
Ensure beta is allowed to be requested
Feb 5, 2025
929876e
New minimum version required by /laravel to allow download
Feb 5, 2025
ebc5dca
Update test package dependency
Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ jobs:
- laravel: 10.*
testbench: ^8.18
carbon: ^2.67
laravel-package-tools: ^1.16
laravel-package-tools: ^1.16.4
collision: 7.*
- laravel: 11.*
testbench: 9.*
carbon: "^2.67|^3.0"
laravel-package-tools: ^1.16
laravel-package-tools: ^1.16.4
collision: ^8.1.1
exclude:
- laravel: 11.*
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
"php": "^8.1",
"illuminate/contracts": "^10.0|^11.0",
"laravel/prompts": "^0.1.1|^0.2|^0.3",
"nativephp/laravel": "^1.0",
"nativephp/laravel": "^1.0@beta",
Comment thread
SRWieZ marked this conversation as resolved.
"nativephp/php-bin": "^0.5.1",
"spatie/laravel-package-tools": "^1.14.0"
"spatie/laravel-package-tools": "^1.16.4"
},
"require-dev": {
"laravel/pint": "^1.0",
Expand Down
3 changes: 2 additions & 1 deletion src/Commands/BuildCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use Native\Electron\Facades\Updater;
use Native\Electron\Traits\InstallsAppIcon;
use Native\Electron\Traits\OsAndArch;
use Symfony\Component\Process\Process as SymfonyProcess;

class BuildCommand extends Command
{
Expand Down Expand Up @@ -60,7 +61,7 @@ public function handle(): void
Process::path(__DIR__.'/../../resources/js/')
->env($this->getEnvironmentVariables())
->forever()
->tty(PHP_OS_FAMILY != 'Windows' && ! $this->option('no-interaction'))
->tty(SymfonyProcess::isTtySupported() && ! $this->option('no-interaction'))
->run("npm run {$buildCommand}:{$os}", function (string $type, string $output) {
echo $output;
});
Expand Down