Skip to content

[22.11] awsebcli: fix up, requests and future dependencies#215468

Merged
vcunat merged 1 commit intoNixOS:release-22.11from
vcunat:p/awsebcli-22.11
Feb 12, 2023
Merged

[22.11] awsebcli: fix up, requests and future dependencies#215468
vcunat merged 1 commit intoNixOS:release-22.11from
vcunat:p/awsebcli-22.11

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Feb 9, 2023

(cherry picked from commit 4fbe3e4)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member Author

vcunat commented Feb 9, 2023

Perhaps the requests part isn't needed, but it should do no harm.

@vcunat
Copy link
Member Author

vcunat commented Feb 9, 2023

Feel free to suggest a different solution for stable. I just noticed that the package wouldn't evaluate now and fixing just eval wouldn't suffice to make it build.

@kirillrdy
Copy link
Member

@vcunat thank you for picking this. I'm not sure how breakage reached 22.11

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Feb 9, 2023
@ofborg ofborg bot requested a review from eqyiel February 9, 2023 09:12
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 9, 2023
@vcunat
Copy link
Member Author

vcunat commented Feb 9, 2023

Surely because of PR #211514

@kirillrdy
Copy link
Member

@vcunat yep that would do that. I'm usually following master not release branches. Thank you either way

@vcunat vcunat merged commit ece36ab into NixOS:release-22.11 Feb 12, 2023
@vcunat vcunat deleted the p/awsebcli-22.11 branch February 19, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants