Skip to content

[MIG][10.0] rating: nothing to do - #1352

Merged
pedrobaeza merged 1 commit into
OCA:10.0from
Tecnativa:10.0-mig-rating
May 29, 2018
Merged

[MIG][10.0] rating: nothing to do#1352
pedrobaeza merged 1 commit into
OCA:10.0from
Tecnativa:10.0-mig-rating

Conversation

@cubells

@cubells cubells commented May 22, 2018

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This analysis file is not correct... this field exists also in v10, but other new fields like rating_image or rating_text are not reported. @StefanRijnhart do you have idea why?

@StefanRijnhart StefanRijnhart May 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah @pedrobaeza you are looking at the analysis of 10.0 so this field should be here. As for rating_image and rating_text in 11.0, these are computed fields and have been traditionally left out of the analysis as they presumably do not need any work.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agh, I have mixed v10 and v11 as we have both. Sorry for the noise.

@pedrobaeza pedrobaeza May 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubells you have to set this to True if rating != -1, which is the previous default value when unset.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Sorry, the correct comparison value is != -1

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza
done!

@pedrobaeza pedrobaeza added this to the 10.0 milestone May 23, 2018
@cubells
cubells force-pushed the 10.0-mig-rating branch 2 times, most recently from 91907ca to 4fb0980 Compare May 24, 2018 09:00
@pedrobaeza

Copy link
Copy Markdown
Member

I'm thinking that for having the same data as in v11, you have to put the field rating to 0 when the value is -1. Maybe that illegal value makes something to crash.

@cubells
cubells force-pushed the 10.0-mig-rating branch 2 times, most recently from 8dda91e to 9e8a41a Compare May 28, 2018 18:18
@cubells

cubells commented May 29, 2018

Copy link
Copy Markdown
Member Author

@pedrobaeza
Can you recheck?

@pedrobaeza

Copy link
Copy Markdown
Member

@cubells you have made the contrary. Read again what I wrote. You need 2 queries.

@cubells
cubells force-pushed the 10.0-mig-rating branch from 9e8a41a to 1804c7a Compare May 29, 2018 08:15
@cubells

cubells commented May 29, 2018

Copy link
Copy Markdown
Member Author

Oops. You are right.
thanks @pedrobaeza

@pedrobaeza
pedrobaeza merged commit 0984919 into OCA:10.0 May 29, 2018
@pedrobaeza
pedrobaeza deleted the 10.0-mig-rating branch May 29, 2018 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants