[MIG][10.0] rating: nothing to do #1352
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| ---Fields in module 'rating'--- | ||
| rating / rating.rating / consumed (boolean) : NEW | ||
|
Member
There was a problem hiding this comment. @cubells you have to set this to True if
Member
There was a problem hiding this comment. EDIT: Sorry, the correct comparison value is |
||
| # Done: update value depending on rating | ||
|
|
||
| ---XML records in module 'rating'--- | ||
| NEW ir.ui.view: rating.rating_external_page_submit | ||
| # Nothing to do | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Copyright 2018 Tecnativa - Vicent Cubells | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
|
|
||
| from openupgradelib import openupgrade | ||
|
|
||
|
|
||
| def update_consumed(env): | ||
| openupgrade.logged_query( | ||
| env.cr, """ | ||
| UPDATE rating_rating rr | ||
| SET consumed = True | ||
| WHERE rating != -1 | ||
| """) | ||
| openupgrade.logged_query( | ||
| env.cr, """ | ||
| UPDATE rating_rating rr | ||
| SET rating = 0 | ||
| WHERE rating = -1 | ||
| """) | ||
|
|
||
|
|
||
| @openupgrade.migrate() | ||
| def migrate(env, version): | ||
| update_consumed(env) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This analysis file is not correct... this field exists also in v10, but other new fields like
rating_imageorrating_textare not reported. @StefanRijnhart do you have idea why?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah @pedrobaeza you are looking at the analysis of 10.0 so this field should be here. As for rating_image and rating_text in 11.0, these are computed fields and have been traditionally left out of the analysis as they presumably do not need any work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agh, I have mixed v10 and v11 as we have both. Sorry for the noise.