Skip to content

Event addon migration - #29

Closed
paulius-sladkevicius wants to merge 58 commits into
OCA:masterfrom
paulius-sladkevicius:event_migration
Closed

Event addon migration#29
paulius-sladkevicius wants to merge 58 commits into
OCA:masterfrom
paulius-sladkevicius:event_migration

Conversation

@paulius-sladkevicius

Copy link
Copy Markdown

Related #20

@bwrsandman

Copy link
Copy Markdown

Forgot to say in #20:
Just update openerp/openupgrade/doc/source/modules70-80.rst to reflect the coverage of the module.
You will need to rebase with upstream/master

git remote add upstream https://github.com/OpenUpgrade/OpenUpgrade.git
git pull --rebase upstream master

@paulius-sladkevicius

Copy link
Copy Markdown
Author

@bwrsandman I've added it

@bwrsandman

Copy link
Copy Markdown

@komsas Thank you!
👍

@paulius-sladkevicius

Copy link
Copy Markdown
Author

Added generic function that can convert text value to HTML.

@bwrsandman

Copy link
Copy Markdown

@komsas nice function, but wouldn't it be more useful to put it in openerp.openupgrade.openupgrade80?

@paulius-sladkevicius

Copy link
Copy Markdown
Author

Firstly we should decide if it's worth to put there. Needs to check if there more places where it could be used.

@bwrsandman

Copy link
Copy Markdown

@StefanRijnhart @hbrunn

wouldn't it be more useful to put convert_field_to_html() in openerp.openupgrade.openupgrade80?

legalsylvain and others added 6 commits June 4, 2014 02:01
…to legalsylvain-base

Conflicts:
	openerp/addons/base/migrations/8.0.1.3/pre-migration.py
Update travis pep8 checking to cover migration files starting in pre- and pro-
[REF] openupgrade_records: sorting key can be a tuple
Base migration finished, based on work from legalsylvain
@legalsylvain

Copy link
Copy Markdown
Contributor

Agree with @bwrsandman remarks.

Sandy Carter and others added 3 commits June 4, 2014 15:20
Don't write to a temp file
Use `load_module` instead of `load_source`

This allows the use of breakpoints in IDEs and in pdb

Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
Simplify migration calling, fix breakpoint use
@StefanRijnhart

Copy link
Copy Markdown
Member

As it is already refactored out, we might as well have it in the API. I would make that openupgrade.py (not openupgrade_80.py) because this is not particularly 8.0 specific.

@paulius-sladkevicius

Copy link
Copy Markdown
Author

@StefanRijnhart in such case I'll try to move it to API

@paulius-sladkevicius

Copy link
Copy Markdown
Author

Sorry, looks by mistake I've merged 8.0 while resolving conflict, but this pull request points to master. I'll prepare a new clean pull request to 8.0.

GuillemCForgeFlow pushed a commit to ForgeFlow/OpenUpgrade that referenced this pull request Oct 10, 2024
Add new context manager allow_pgcodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants