[FIX] Correctly detect new API function, property and related fields - #382
Merged
Merged
Conversation
This was referenced Oct 12, 2015
Member
There was a problem hiding this comment.
This is a good candidate for being refactored to a method that can be called from the multiple places where you are making this change.
Member
Author
There was a problem hiding this comment.
Can I call on the rule of three here, and not do this now?
Member
There was a problem hiding this comment.
Of course, no problem. I told it as I see the same replace in several places, but indeed there are only 2 appearances.
Member
|
👍 |
Closed
pedrobaeza
added a commit
that referenced
this pull request
Oct 29, 2015
[FIX] Correctly detect new API function, property and related fields
locdang8
pushed a commit
to locdang8/OpenUpgrade
that referenced
this pull request
Jul 20, 2023
* [OA-ADD] purchase: migration analytic distribution * Update openupgrade_scripts/scripts/purchase/16.0.1.2/upgrade_analysis_work.txt --------- Co-authored-by: Roy Le <43790414+royleviindoo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes confusion between related and computed fields (related fields are computed according to their related path).
Implements detection of fields becoming a property field (not seen in the wild, but still).
Prevent signalling new 'monetary' field as distinct from 'float' field.
Take 'default' attribute on new API fields into account.