Skip to content

[FIX] Correctly detect new API function, property and related fields - #384

Merged
pedrobaeza merged 1 commit into
OCA:7.0from
StefanRijnhart:7.0-framework_new_api_fields
Oct 29, 2015
Merged

[FIX] Correctly detect new API function, property and related fields#384
pedrobaeza merged 1 commit into
OCA:7.0from
StefanRijnhart:7.0-framework_new_api_fields

Conversation

@StefanRijnhart

Copy link
Copy Markdown
Member

Backport of #382

@StefanRijnhart StefanRijnhart added this to the 7.0 milestone Oct 12, 2015
@StefanRijnhart
StefanRijnhart force-pushed the 7.0-framework_new_api_fields branch from 113dbbe to ad53a5e Compare October 12, 2015 19:37
@pedrobaeza

Copy link
Copy Markdown
Member

I don't think this problem was so old...

👍

@StefanRijnhart

Copy link
Copy Markdown
Member Author

Yes, it could be down there all the way back to 5.0 but I am not sure if it is worthwhile to backport it further down. I looked at 6.1 but the cherry pick wasn't exactly clean due to some refactorings in the OpenUpgrade patches between 6.1 and 7.0 so I decided to stop here for now. This is only a problem if someone wants to do an analysis between 6.1 and 7.0. Such an analysis will contain false message on all related fields, saying that they are not function fields anymore.

@pedrobaeza

Copy link
Copy Markdown
Member

Well, I don't think this kind of analysis is going to be done anymore. As the scripts and the analysis for standard modules is there, and a direct code analysis can make the rest, I don't think necessary. Maybe a mention on the module description can help, but you're making enough.

Off-topic: I migrate from 6.1 my last customer 2 weeks ago! (one that resists to go through version 7).

pedrobaeza added a commit that referenced this pull request Oct 29, 2015
[FIX] Correctly detect new API function, property and related fields
@pedrobaeza
pedrobaeza merged commit 015ce87 into OCA:7.0 Oct 29, 2015
GuillemCForgeFlow pushed a commit to ForgeFlow/OpenUpgrade that referenced this pull request Oct 10, 2024
* [IMP]convert_field_to_html: manage translated fields

---------

Co-authored-by: clementthomas <clement@cotyl.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants