[17.0][OU-FIX] account: Avoid the error when executing the migrate_translations_to_jsonb method - #5369
Conversation
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Isn't Odoo in between pre and post doing anything with the column or giving an error?
|
👍 It is working for me and fixing #5368 |
|
lgtm |
|
wait a second here, are we sure this actually does something? The ir_translation->jsonb transition was 15->16, so if in v16 the field was translatable, it was a json field all along. @victoralmau is it possible you're migrating a database that has been migrated from v15 already, and what you're "fixing" here is actually a followup issue from the v16 migration? Because I don't see how |
|
Remember that this happens only with |
|
yes, but still The only way I can imagine is that you had translations in v15, migrated to v16 and for whatever reason then the translations didn't end up in the json columns. |
|
I can't say right now. @victoralmau can you answer? |
…tion() method in post-migration. Related to OCA#5369 (comment) This change is not necessary because when migrating from 15 to 16, the description column in account_tax will already be json (https://github.com/OCA/OpenUpgrade/blob/4af8572c7f3e313773db558ba382b5ffd19a157c/openupgrade_scripts/scripts/base/16.0.1.3/end-migration.py#L39), therefore, in v17, you only need to rename the column (this is already done in pre-migration). TT57778
5 participants
Avoid the error when executing the migrate_translations_to_jsonb method
Related to #5355
Fixes #5368
Please @pedrobaeza and @hbrunn can you review it?
@Tecnativa