[17.0][OU-FIX] account: Remove the unnecessary _convert_account_tax_description() method in post-migration. - #5377
Merged
Conversation
…tion() method in post-migration. Related to OCA#5369 (comment) This change is not necessary because when migrating from 15 to 16, the description column in account_tax will already be json (https://github.com/OCA/OpenUpgrade/blob/4af8572c7f3e313773db558ba382b5ffd19a157c/openupgrade_scripts/scripts/base/16.0.1.3/end-migration.py#L39), therefore, in v17, you only need to rename the column (this is already done in pre-migration). TT57778
hbrunn
approved these changes
Sep 15, 2025
Member
|
we should restore the state before your first pr though I think, with converting the column, right? |
Member
Author
There is no need to convert anything, the column is already json in the database (since 16). |
pedrobaeza
approved these changes
Sep 15, 2025
Member
|
not when it's not translated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unnecessary _convert_account_tax_description() method in post-migration.
Related to #5369 (comment)
This change is not necessary because when migrating from 15 to 16, the description column in account_tax will already be json (
OpenUpgrade/openupgrade_scripts/scripts/base/16.0.1.3/end-migration.py
Line 39 in 4af8572
Please @pedrobaeza and @hbrunn can you review it?
@Tecnativa TT57778