[ADD] base - #789
Merged
Merged
Conversation
hbrunn
force-pushed
the
10.0-base
branch
2 times, most recently
from
April 4, 2017 16:48
29fbe4c to
369f79e
Compare
Merged
StefanRijnhart
approved these changes
Apr 13, 2017
StefanRijnhart
left a comment
StefanRijnhart
left a comment
Member
There was a problem hiding this comment.
I would merge this optimistically, but you requested a merge from @pedrobaeza.
Member
|
Loading changes in noupdate data here: hbrunn#1 |
[ADD] Noupdate data changes for base
Member
Author
|
@StefanRijnhart this is not how I understand the requested reviews feature, so your merge will be just as welcome as @pedrobaeza's to me |
Member
|
I guess the meaning is in the eyes of the beholder. You meant just to notify @pedrobaeza then? Anyway, merging now! |
pedrobaeza
reviewed
Apr 14, 2017
| base / res.currency / symbol (char) : now required | ||
| # TODO: pre-migration: Use the value of name if symbol is blank | ||
| # Use the value of name if symbol is blank | ||
| base / res.partner / birthdate (char) : DEL |
Member
There was a problem hiding this comment.
It's a good practice to rename these fields to None in case they are needed by other module. database_cleanup can later purge the column if you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if this works, I propose to change the default branch to 10, this way also getting the correct documentation on https://doc.therp.nl/openupgrade