Skip to content

[10.0][ADD] Updated 'openupgrade_analysis.txt' files. - #850

Closed
reinka wants to merge 1 commit into
OCA:10.0from
reinka:10.0-add-update-analysis-txt
Closed

[10.0][ADD] Updated 'openupgrade_analysis.txt' files.#850
reinka wants to merge 1 commit into
OCA:10.0from
reinka:10.0-add-update-analysis-txt

Conversation

@reinka

@reinka reinka commented May 29, 2017

Copy link
Copy Markdown

Description of the issue/feature this PR addresses:
@pedrobaeza @jbeficent @StefanRijnhart @NL66278 After running openupgrade analysis again, we saw there have been some changes since the first openupgrade analysis back in Oct 2016. This was the motivation for checking and updating all related migration scripts if needed.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@rruebner rruebner mentioned this pull request May 29, 2017
@reinka reinka mentioned this pull request May 29, 2017
@omar7r

omar7r commented May 29, 2017

Copy link
Copy Markdown

👍

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approved, but I would like to know @StefanRijnhart's opinion

@NL66278 NL66278 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is clear that something is wrong with the analysis text. Many fields are now said to be in the hw_ecspos module, but that does not have any models at all.

The first change in this PR says currency_id is in hw_ecspos instead of in analytic. In reality it is in analytic still.

@pedrobaeza

Copy link
Copy Markdown
Member

I think we need to blacklist this module because it explodes the system for having an stripped version for PosBox

@NL66278

NL66278 commented May 30, 2017

Copy link
Copy Markdown

@pedrobaeza Actually the module is in odoo/addons/openupgrade_records/blacklist.py.

But the blacklist might me needed in more places then used now.

@pedrobaeza

Copy link
Copy Markdown
Member

Yeah, it seems so. Then I bet now simply to remove the folder manually for making the analysis.

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove my approval meanwhile

@StefanRijnhart

Copy link
Copy Markdown
Member

I arrive at the following changes: #871

@NL66278

NL66278 commented May 31, 2017

Copy link
Copy Markdown

I would recommend closing this in favor of Stefan's PR: #871

@hbrunn

hbrunn commented Jun 6, 2017

Copy link
Copy Markdown
Member

closing as this is superseded by #871

@hbrunn hbrunn closed this Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants