[10.0][MIG] sale - #851
Conversation
There was a problem hiding this comment.
Typo: there are 4 extra spaces. :)
There was a problem hiding this comment.
Please check it if warning module was installed on v9 and rescue values from it.
There was a problem hiding this comment.
You can use openupgradelib map_values function for readibility and extra log.
|
@pedrobaeza I updated the migration parts according to your mentioned points. In addition I rechecked all parts again and added some more migration parts. |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Check if you need to rename the security groups
|
@pedrobaeza I fixed the mentioned typos and rechecked security group changes. AFAICS there is no extra renaming needed (possible renaming is covered by update_module_names calls). |
|
Thanks for the changes, Robert. If you don't mind, I'm going to keep the PRs unmerged until we get a green branch for not adding more complexity to the pipe and possible side effects. |
|
Please, rebase the PR (and squash minor commits) |
There was a problem hiding this comment.
A new line appeared https://github.com/OCA/OpenUpgrade/pull/917/files#diff-1c07737aeb217d5e147f8fa6d1204414R5, and it should be attended in an easy post-migration script.
There was a problem hiding this comment.
If you don't have installed "sale_layout" module, columns renaming and the models renaming fails, maybe, you have to check if this module is installed to execute this two functions
|
This fails due to TRAVIS_COMMIT, but I have checked it and fix it, so I merge. |
6 participants
FYI: I also updated the analysis text file for the sale module here. The rest of the analysis text files were updated in #850.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr