(WIP) Product v8 migration - #9
Closed
gurneyalex wants to merge 19 commits into
Closed
Conversation
XML ID migration complete
…Upgrade into product-v8-migration
|
I changed the title to reflect that this as a WIP. |
bwrsandman
changed the title
Member
There was a problem hiding this comment.
The comparison script should ignore demo data. This change is (also) in product_data.xml.
Member
|
Thanks, looks great so far. Just a couple of questions there. We could either merge this when these questions have been resolved, or wait for the completion of the scripts. |
gurneyalex
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work in progress, but it is running.
Feedback welcome.