[IMP] website_sale_require_legal: record metadata on registration and acceptance of conditions#235
Merged
pedrobaeza merged 2 commits intoOCA:9.0from Jun 4, 2018
Conversation
chienandalu
force-pushed
the
9.0-imp-website_sale_require_legal_gdpr
branch
from
4ef8a03 to
c91f026
Compare
chienandalu
changed the title
pedrobaeza
approved these changes
Jun 1, 2018
Member
Author
|
Can we fix the website_sale_wishlist .rst with a direct commit from here 219e1c0 for this branch? |
Member
|
Done, please rebase. |
chienandalu
force-pushed
the
9.0-imp-website_sale_require_legal_gdpr
branch
from
c91f026 to
7842b22
Compare
Member
Author
|
Great, green now @rafaelbn Can you review? |
yajo
requested changes
Jun 4, 2018
| ) | ||
| website_user = (request.website.salesperson_id.id or | ||
| SUPERUSER_ID) | ||
| partner_id.sudo(website_user).message_post(body=metadata) |
Member
There was a problem hiding this comment.
Please explain in README where to find acceptance metadata. One might think it will be in the SO instead.
| if partner_id: | ||
| environ = request.httprequest.headers.environ | ||
| metadata = "Website legal terms acceptance metadata: " | ||
| metadata += "\n".join( |
Member
There was a problem hiding this comment.
It seems you need to use <br/> instead.
Member
Author
|
@yajo Changes done |
yajo
approved these changes
Jun 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the module GDPR compliant
cc @Tecnativa