11.0 mig website_sale_require_legal by ernestotejeda · Pull Request #237 · OCA/e-commerce

ernestotejeda · 2018-06-04T00:00:34Z

Normal migration

Update README

chienandalu

Thanks for your work @ernestotejeda You should migrate from 10.0 though (https://github.com/OCA/e-commerce/tree/10.0/website_sale_require_legal) wich has several improvements like gdpr compliance, etc.

rafaelbn · 2018-06-05T04:59:19Z

Thanks @ernestotejeda !

@Tecnativa previous PR:

v9: [IMP] website_sale_require_legal: record metadata on registration and acceptance of conditions #235
v10: [MIG][website_sale_require_legal] Migrate to v10 #205

This is a set of @gdpr improvements

rafaelbn · 2018-06-12T14:57:12Z

Please @chienandalu review again, thanks!

yajo · 2018-06-12T14:57:15Z

website_sale_require_legal/readme/CONTRIBUTORS.rst

+* David Vidal <david.vidal@tecnativa.com>
+* `Tecnativa <https://www.tecnativa.com>`_:
+
+  * Ernesto Tejeda <ernesto.tejeda87@gmail.com>


All the above are from tecnativa too, put them here.

yajo · 2018-06-12T14:58:01Z

website_sale_require_legal/readme/INSTALL.rst

@@ -0,0 +1,3 @@
+To install this module, you need to:
+
+* Install repository `OCA/website <https://github.com/OCA/website>`_.


This is implicit, remove it please. (People get dependencies when downloading from apps.odoo.com)

In PR #238 @chienandalu comment something like this, and @pedrobaeza answered:
That's not true. You have to indicate dependencies outside of the current repo, which is the case.

Please, check that and confirm me what i should do, thanks.

rafaelbn · 2018-06-12T16:00:50Z

@ernestotejeda please review runbot warning:

2018-06-12 15:12:26,448 169 WARNING openerp_test odoo.addons.base.ir.ir_ui_view: Error-prone use of @class in view address (): use the hasclass(*classes) function to filter elements by their classes
2018-06-12 15:12:26,460 169 INFO openerp_test odoo.modules.loading: loading website_sale_require_legal/demo/assets.xml
2018-06-12 15:12:26,537 169 WARNING openerp_test odoo.addons.base.ir.ir_ui_view: Error-prone use of @class in view address (website_sale_require_legal.address): use the hasclass(*classes) function to filter elements by their classes

yajo

Almost perfect, just one last detail.

yajo · 2018-06-13T09:22:15Z

website_sale_require_legal/controllers/main.py

+                all_values.get('accepted_legal_terms')):
+            environ = request.httprequest.headers.environ
+            metadata = "Website legal terms acceptance metadata: "
+            metadata += "\n".join(


Use <br/> instead. This is what you get now:

rafaelbn · 2018-06-13T13:23:19Z

Hi @ernestotejeda tested functionally it doesn't work. There in not legal advice and checkbox:

rafaelbn

Need fixing

rafaelbn

Sorry, someone uninstall de module....
Tested functionality 👍

rafaelbn · 2018-06-13T13:59:04Z

Please @ernestotejeda add test

codecov/patch — 65.62% of diff hit (target 100%)
codecov/project — 75% (-25%) compared to 14117f2

Thank you

yajo · 2018-06-14T15:14:25Z

Awesome. Please squash migration commits, to merge. Thanks! 😉

chienandalu suggested changes Jun 4, 2018

View reviewed changes

rafaelbn added this to the 11.0 milestone Jun 5, 2018

rafaelbn added the work in progress label Jun 5, 2018

yajo and others added 6 commits June 11, 2018 23:58

[ADD] website_sale_require_legal

058b6de

[9.0] [MIG] website_sale_require_legal module

3785a9b

OCA Transbot updated translations from Transifex

2c32fb3

[MIG][website_sale_require_legal] Migrate to v10

8f853bc

website_sale_require_legal: Fix rendering error when error list is empty

8a4d08e

[IMP] record metadata on registration and acceptance of conditions

38d9793

ernestotejeda force-pushed the 11.0-mig-website_sale_require_legal branch from 05d64c1 to de2310b Compare June 12, 2018 14:15

rafaelbn added needs review and removed work in progress labels Jun 12, 2018

yajo approved these changes Jun 12, 2018

View reviewed changes

chienandalu approved these changes Jun 12, 2018

View reviewed changes

yajo requested changes Jun 13, 2018

View reviewed changes

rafaelbn requested changes Jun 13, 2018

View reviewed changes

rafaelbn added needs fixing approved and removed needs fixing labels Jun 13, 2018

rafaelbn approved these changes Jun 13, 2018

View reviewed changes

rafaelbn removed the approved label Jun 13, 2018

yajo approved these changes Jun 14, 2018

View reviewed changes

[MIG] website_sale_require_legal: Migration to 11.0

42c3305

ernestotejeda force-pushed the 11.0-mig-website_sale_require_legal branch from dbc5c73 to 42c3305 Compare June 14, 2018 23:14

pedrobaeza merged commit 490bc3d into OCA:11.0 Jun 18, 2018

pedrobaeza mentioned this pull request Jun 18, 2018

Migration to version 11.0 #208

Closed

22 tasks

		@@ -0,0 +1,3 @@
		To install this module, you need to:

		* Install repository `OCA/website <https://github.com/OCA/website>`_.

Uh oh!

Conversation

ernestotejeda commented Jun 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chienandalu left a comment

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Jun 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rafaelbn commented Jun 12, 2018

Uh oh!

yajo Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

yajo Jun 12, 2018

Choose a reason for hiding this comment

Uh oh!

ernestotejeda Jun 13, 2018

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Jun 12, 2018

Uh oh!

yajo left a comment

Choose a reason for hiding this comment

Uh oh!

yajo Jun 13, 2018

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Jun 13, 2018

Uh oh!

rafaelbn left a comment

Choose a reason for hiding this comment

Uh oh!

rafaelbn left a comment

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Jun 13, 2018

Uh oh!

yajo commented Jun 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ernestotejeda commented Jun 4, 2018 •

edited

Loading

rafaelbn commented Jun 5, 2018 •

edited

Loading

yajo commented Jun 14, 2018 •

edited

Loading