11.0 mig website_sale_product_brand by ernestotejeda · Pull Request #238 · OCA/e-commerce

ernestotejeda · 2018-06-04T00:03:17Z

chienandalu

You need to declare oca_dependencies.txt with product-attribute repo.
You should also use the new OCA readme system

chienandalu · 2018-06-04T09:03:41Z

website_sale_product_brand/README.rst

+is related to this brand.
+
+The blog here explains the HOWTO :
+    http://www.serpentcs.com/serpentcs-odoo-ecommerce-shop-brands-contribution


Do this link give any relevant info? The README.rst info should be the more self contained possible

Indeed no links outside OCA

chienandalu · 2018-06-04T09:04:58Z

website_sale_product_brand/README.rst

+It will allow you to filter product based on its brand.
+
+While shopping online, we have seen various eShops having a feature to shop by brands
+which ODOO does not yet provide officially.Website Sale Product Brand fills the gap at certain


Need a space between officially. and Website

chienandalu · 2018-06-04T09:05:43Z

website_sale_product_brand/__manifest__.py

+    'category': 'e-commerce',
+    'author': "Serpent Consulting Services Pvt. Ltd.,"
+              "Odoo Community Association (OCA)",
+    'website': 'http://www.serpentcs.com',


https://github.com/OCA/e-commerce

chienandalu · 2018-06-04T09:06:27Z

website_sale_product_brand/README.rst

+============
+
+To install this module, you need to install following module:
+->https://github.com/OCA/product-attribute/tree/11.0/product_brand


Dependencies are already documented in the manifest file

That's not true. You have to indicate dependencies outside of the current repo, which is the case.

pedrobaeza · 2018-06-04T09:09:58Z

@ernestotejeda you have to include in oca_dependencies.txt file in the root the repository product-attribute for having correct Travis and runbot.

rafaelbn

Set as WIP cc @Tecnativa

rafaelbn · 2018-06-05T05:10:09Z

website_sale_product_brand/__manifest__.py

+    'name': 'Product Brand Filtering in Website',
+    'category': 'e-commerce',
+    'author': "Serpent Consulting Services Pvt. Ltd.,"
+              "Odoo Community Association (OCA)",


@JayVora-SerpentCS @pedrobaeza we are maintaining this module from v9 with fix + improvement + migrating. Do you think is fair to add here Tecnativa o not?

Fine to add @rafaelbn ! Thanks.

rafaelbn · 2018-06-05T06:06:24Z

cc @Tecnativa

MeetKD · 2018-06-05T16:17:10Z

website_sale_product_brand/README.rst

@@ -0,0 +1,95 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg


Better to use new README by fragments system. @ernestotejeda check other of your PRs where I have done it.

MeetKD · 2018-06-07T06:04:45Z

website_sale_product_brand/views/product_brand.xml

@@ -0,0 +1,62 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>


No description provided.

rafaelbn · 2018-06-12T14:52:08Z

Please @ernestotejeda could you review this PR , we can't review it. Thanks! 😄

MeetKD

LGTM 👍

yajo · 2018-06-13T09:53:18Z

website_sale_product_brand/__manifest__.py

    ],
+    'demo': [
+        "demo/assets.xml",
+        "data/brand_data.xml"


Demo data goes into demo folder. Also please append trailing ,

yajo · 2018-06-13T09:56:11Z

website_sale_product_brand/static/src/js/tour.js

+    var steps = [
+        {
+            trigger: "a[href='/page/product_brands']",
+            content: _t("Go to 'Product brand' page"),


If this tour is only for testing (not for guiding first-time users), then don't translate strings.

yajo · 2018-06-13T09:56:29Z

website_sale_product_brand/tests/__init__.py

@@ -0,0 +1,4 @@
+# -*- coding: utf-8 -*-


yajo · 2018-06-13T09:57:03Z

website_sale_product_brand/tests/test_ui.py

+class UICase(HttpCase):
+    def setUp(self):
+        """Ensure website lang is en_US."""
+        super(UICase, self).setUp()


🔥 This method does nothing? 🤔

JGarcia-Panach

Fucntional review 👍

rafaelbn

Please @ernestotejeda review technical commments, Functionally is OK 👍

chienandalu · 2018-06-20T08:22:42Z

website_sale_product_brand/demo/product_brand_demo.xml

+    <record id="product_brand_apple_demo" model="product.brand">
+        <field name="name">Apple</field>
+    </record>
+</odoo>


Add an EOF empty line

chienandalu · 2018-06-20T08:22:47Z

website_sale_product_brand/demo/product_product_demo.xml

+    <record id="product.product_product_9" model="product.product">
+        <field name="product_brand_id" ref="product_brand_apple_demo"/>
+    </record>
+</odoo>


Add an EOF empty line

[ADD][website_sale_wishlist] Wishlist for your online shop. Allow your visitors and users to wishlist your products and have a shortcut for seeing them. Wishlisted products are stored in the session for public users, and linked to the user if s/he is logged in.

pedrobaeza · 2018-06-20T23:06:34Z

As @yajo's comments have been honored, I merge this.

chienandalu suggested changes Jun 4, 2018

View reviewed changes

rafaelbn added this to the 11.0 milestone Jun 5, 2018

rafaelbn added the work in progress label Jun 5, 2018

rafaelbn self-requested a review June 5, 2018 05:03

rafaelbn reviewed Jun 5, 2018

View reviewed changes

MeetKD suggested changes Jun 7, 2018

View reviewed changes

ernestotejeda mentioned this pull request Jun 13, 2018

11.0 mig website_sale_require_legal #237

Merged

MeetKD approved these changes Jun 13, 2018

View reviewed changes

pedrobaeza force-pushed the 11.0-mig-website_sale_product_brand branch from 307bade to 2d94091 Compare June 13, 2018 08:37

rafaelbn added needs review and removed work in progress labels Jun 13, 2018

rafaelbn closed this Jun 13, 2018

rafaelbn reopened this Jun 13, 2018

yajo requested changes Jun 13, 2018

View reviewed changes

JGarcia-Panach approved these changes Jun 13, 2018

View reviewed changes

OCA deleted a comment from JGarcia-Panach Jun 13, 2018

rafaelbn approved these changes Jun 13, 2018

View reviewed changes

chienandalu reviewed Jun 20, 2018

View reviewed changes

MeetSCS and others added 9 commits June 21, 2018 00:25

[IMP]Changed name of module.

7792991

[MIG]Migrated shop_by_brand module in v9.

1f9cd9e

FIX avoid messing up website_sale controller inheritance

18eafde

OCA Transbot updated translations from Transifex

471da10

OCA Transbot updated translations from Transifex

b36352b

[FIX] website_sale_product_brand: Page not found in category pagination

d619ff3

OCA Transbot updated translations from Transifex

2d3f101

[MIG] website_sale_product_brand: Migration to 11.0

e23cb6d

pedrobaeza force-pushed the 11.0-mig-website_sale_product_brand branch from eaa5741 to e23cb6d Compare June 20, 2018 22:26

pedrobaeza merged commit c5c39da into OCA:11.0 Jun 20, 2018

pedrobaeza mentioned this pull request Jun 20, 2018

Migration to version 11.0 #208

Closed

22 tasks

		@@ -0,0 +1,95 @@
		.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg

		@@ -0,0 +1,62 @@
		<?xml version="1.0" encoding="utf-8"?>
		<openerp>

Uh oh!

Conversation

ernestotejeda commented Jun 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chienandalu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Jun 4, 2018

Uh oh!

rafaelbn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Jun 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Jun 12, 2018

Uh oh!

MeetKD left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JGarcia-Panach left a comment

Choose a reason for hiding this comment

Uh oh!

rafaelbn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Jun 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

ernestotejeda commented Jun 4, 2018 •

edited

Loading