[11.0][IMP] attachment_preview: Split screen#194
Conversation
tarteo
changed the title
b4490c1 to
111fe95
Compare
|
It looks very fine!!! |
|
I think this should be configurable, or to have 2 icons: one for seeing it inline and another in the previous new tab behavior. |
|
@pedrobaeza Currently the split screen always opens first. On the split screen there's a button to open it in a new tab. I can add an user preference (like 'Open attachment preview first in split screen') or an extra button to open it directly in a new tab. |
|
Yeah, I didn't want to lose the option to open it in a new tab. |
|
I'll make an user preference. So people who never want to use the split screen can open the attachment in a tab with only one click. |
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
cool! I'm just not very good with UI stuff, and am happy when others fix this then. I'll merge after you've rebased
|
@tarteo Man 👍 |
|
Can you rebase to resolve the conflict? |
[FIX] Grammar splitted > split [ADD] Extra open in new tab button
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
56af176 to
e8e6b34
Compare
|
I failed. I'll make a new PR. #200 |
6 participants
This PR adds a new functionality to the attachment_preview. When you open a preview from the attachments menu in the form view. It opens it in a split screen next to the form view: