[10.0][MIG] attachment_preview migration#199
Conversation
[FIX] Remove unnecesarry piece of code [FIX] Test coverage [FIX] Test coverage [FIX] Test coverage
e7c583f to
fd8cb98
Compare
yung-wang
left a comment
There was a problem hiding this comment.
Tested and i can see the preview. OK
|
This PR has the |
astirpe
left a comment
There was a problem hiding this comment.
Tested in Runbot: OK. Code review: OK.
|
Can this be merged, please 😁 |
|
/ocabot merge |
|
Sorry @rafaelbn you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
/ocabot merge |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-199-by-pedrobaeza-bump-no. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Please rebase and fix the conflict as I needed to fix Travis CI |
|
@pedrobaeza Done |
|
/ocabot merge |
|
On my way to merge this fine PR! |
|
@pedrobaeza The merge process could not be finalized, because command |
|
@tarteo please never use GitHub conflict resolution, as it totally messes the commit history. Thanks to bot we have discovered the problem before the merge! |
|
@pedrobaeza I created a new PR with the rebase #224 |
Backport of #194