[12.0]Multiple UI / UX Improvements - #318
Conversation
[IMP]Image on category
Currently translated at 100.0% (2 of 2 strings) Translation: knowledge-12.0/knowledge-12.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-attachment_preview/tr/
|
I would like to propose some imrpovements for the documentation. This PR is not yet finished but I would like to share with you what I've done. I would like to receive your feedback on this orientation and of course on the code itself. Thanks in advance for your futures comments |
|
Everything is red, so can't be testable. |
|
This time it should be OK. |
|
@pedrobaeza @max3903 you have now something to test, I'll check travis ASAP |
|
hummm... it seems that we're facing this kind of issue : odoo/odoo#30881 |
|
@pedrobaeza @max3903 this one is ready for review, all is green |
|
hi @legalsylvain , any review possible here ? |
|
I don't use this module. No point of view regarding the changes. |
[IMP]Image on category
[IMP]Image on category
…AndGo/knowledge into 12.0-IMP-multipleImprovements
|
Hey @flotho, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
Hi @yavuzavci , it seems that you haven't signed CLA, any chance to update this ? Regards |
|
yihaaa.... at last everything is green. |
|
Please summarize the changes in the initial comment + squash commit history merging properly commits. I see that you have made a lot of cosmetic changes that were only warnings, not errors. That's appreciated, but it's convenient to split that ones in a different PR, or at least, commit. |
|
@pedrobaeza , ok for explaining, can I keep the "cosmetics changes" in this PR ? |
|
OK as long as you keep it in a separate commit for being discriminated when reviewing the PR. The rest of the changes may go together if the same author or logical set. |
Hi, I've done it as of today. It shouldn't be a problem anymore. |
|
close this one in favor of #324 |
No description provided.