Skip to content

[12.0]Multiple UI / UX Improvements - #318

Closed
flotho wants to merge 35 commits into
OCA:12.0from
MindAndGo:12.0-IMP-multipleImprovements
Closed

[12.0]Multiple UI / UX Improvements #318
flotho wants to merge 35 commits into
OCA:12.0from
MindAndGo:12.0-IMP-multipleImprovements

Conversation

@flotho

@flotho flotho commented Dec 23, 2021

Copy link
Copy Markdown
Member

No description provided.

@flotho

flotho commented Feb 2, 2022

Copy link
Copy Markdown
Member Author

Hi @pedrobaeza @max3903

I would like to propose some imrpovements for the documentation. This PR is not yet finished but I would like to share with you what I've done.
Our team of dev and not dev user have many troubles to navigate in the pages menu and this was an obstacle for the acceptance of this module.
After many discussion we decided to improve the way we could navigate in the content, and this is the main object of my proposal.
The ideas is to be able to browse easily between category and content in the same view like in simple content management organised in shelves, chapter, pages, etc...

I would like to receive your feedback on this orientation and of course on the code itself.

Thanks in advance for your futures comments

@pedrobaeza

Copy link
Copy Markdown
Member

Everything is red, so can't be testable.

@flotho flotho closed this Feb 5, 2022
@flotho flotho reopened this Feb 5, 2022
@flotho
flotho marked this pull request as ready for review February 5, 2022 22:23
@flotho flotho closed this Feb 5, 2022
@flotho flotho reopened this Feb 5, 2022
@flotho flotho closed this Feb 5, 2022
@flotho flotho reopened this Feb 5, 2022
@flotho

flotho commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

This time it should be OK.
I tried to add prettier / pylint precommit and all the stuff. It refactored more files than expected, sorry for that.*
Ready for reviews !

@flotho

flotho commented Feb 7, 2022

Copy link
Copy Markdown
Member Author

@pedrobaeza @max3903 you have now something to test, I'll check travis ASAP

@flotho

flotho commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

hummm... it seems that we're facing this kind of issue : odoo/odoo#30881

@flotho

flotho commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

@pedrobaeza @max3903 this one is ready for review, all is green

@flotho

flotho commented Feb 9, 2022

Copy link
Copy Markdown
Member Author

hi @legalsylvain , any review possible here ?

@legalsylvain

Copy link
Copy Markdown

I don't use this module. No point of view regarding the changes.
Note : you have introduced an empty file named "chmod".

@oca-clabot

Copy link
Copy Markdown

Hey @flotho, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@flotho

flotho commented Feb 9, 2022

Copy link
Copy Markdown
Member Author

Hi @yavuzavci , it seems that you haven't signed CLA, any chance to update this ?

Regards

@flotho

flotho commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

yihaaa.... at last everything is green.
Ready for review !

@pedrobaeza

Copy link
Copy Markdown
Member

Please summarize the changes in the initial comment + squash commit history merging properly commits. I see that you have made a lot of cosmetic changes that were only warnings, not errors. That's appreciated, but it's convenient to split that ones in a different PR, or at least, commit.

@flotho

flotho commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

@pedrobaeza , ok for explaining, can I keep the "cosmetics changes" in this PR ?

@pedrobaeza

Copy link
Copy Markdown
Member

OK as long as you keep it in a separate commit for being discriminated when reviewing the PR. The rest of the changes may go together if the same author or logical set.

@yavuzavci

Copy link
Copy Markdown
Contributor

Hi @yavuzavci , it seems that you haven't signed CLA, any chance to update this ?

Regards

Hi,

I've done it as of today. It shouldn't be a problem anymore.

@flotho

flotho commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

close this one in favor of #324

@flotho flotho closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants