Skip to content

[12.0]IMP: Add single menu for content browsing - #324

Merged
OCA-git-bot merged 1 commit into
OCA:12.0from
MindAndGo:12.0-IMP-browse-wiki-content
Feb 23, 2022
Merged

[12.0]IMP: Add single menu for content browsing#324
OCA-git-bot merged 1 commit into
OCA:12.0from
MindAndGo:12.0-IMP-browse-wiki-content

Conversation

@flotho

@flotho flotho commented Feb 10, 2022

Copy link
Copy Markdown
Member
  • Categories and content are now available and browsable in a single menu.
  • Navigation helps user to find content easily
  • Cleanups for pylint and flake

superseeds #318

* Categories and content are now available and browsable in a single menu.
* Navigation helps user to find content easily
* Cleanups for pylint and flake
@flotho flotho changed the title IMP: Add single menu for content browsing [12.0]IMP: Add single menu for content browsing Feb 10, 2022
@flotho

flotho commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

Hi @pedrobaeza , @yavuzavci , this one is ready for review, green and obvisously more simple to read.

Thanks

@flotho

flotho commented Feb 15, 2022

Copy link
Copy Markdown
Member Author

any chance to be reviewed ?

@flotho

flotho commented Feb 16, 2022

Copy link
Copy Markdown
Member Author

@jacob88 maybe you could have a look / review to my improvements I'll do the same to your PR #320

@flotho

flotho commented Feb 18, 2022

Copy link
Copy Markdown
Member Author

I suppose that friday is OCA merge day so I try an additionnal ping @pedrobaeza @yavuzavci and @jacob88 to be reviewed on this one.
Thanks

@flotho

flotho commented Feb 23, 2022

Copy link
Copy Markdown
Member Author

Hi, @gurneyalex @max3903 @hbrunn @lmignon @etobella , I contact you as team members of this repo.
Is it possible to be reviewed?

Thanks

@lmignon

lmignon commented Feb 23, 2022

Copy link
Copy Markdown

@flotho It's very difficult to review since cleanup and changes are all into the same commit...

@flotho

flotho commented Feb 23, 2022

Copy link
Copy Markdown
Member Author

@flotho It's very difficult to review since cleanup and changes are all into the same commit...

you're right I understand. I'll try my best ASAP

@lmignon

lmignon commented Feb 23, 2022

Copy link
Copy Markdown

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-324-by-lmignon-bump-nobump, awaiting test results.

@flotho

flotho commented Feb 23, 2022

Copy link
Copy Markdown
Member Author

thanks to both of you, I promise to work better next time and separate properly commits

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
OCA-git-bot merged commit 57393d3 into OCA:12.0 Feb 23, 2022
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 3a0cd4a. Thanks a lot for contributing to OCA. ❤️

@lmignon

lmignon commented Feb 23, 2022

Copy link
Copy Markdown

Thank you to you for your contribution @flotho !

@flotho

flotho commented Feb 23, 2022

Copy link
Copy Markdown
Member Author

do you enjoy this feature @lmignon ?

@lmignon

lmignon commented Feb 23, 2022

Copy link
Copy Markdown

Unfortunately, I cannot answer the question. It is a module that I do not use.

@flotho

flotho commented Feb 24, 2022

Copy link
Copy Markdown
Member Author

could you point me the proper way to port this in netx release please ?

@lmignon

lmignon commented Feb 24, 2022

Copy link
Copy Markdown

@flotho The migration process is explained here

@pedrobaeza pedrobaeza added this to the 12.0 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants