[9.0] knowledge

[naousse]

The knowledge module has been deprecated by Odoo SA in version 9.0. This pull request is a port of this module to provide:

• a top-level menu item
• submenus with a settings panel to configure knowledge and document applications
• groups and access rights

[pedrobaeza]

But why do you need this module? This module was only a wrapper to allow certain configuration, but per se doesn't add any model. I don't think it's needed.

[naousse]

OK.
The module document_page need it, and it is the module that add the menu for knowledge operation.

[naousse]

So, do i remove it as requirement for document_page module?

[pedrobaeza]

Yes, I think it's the way to go. See if in current v9 menu layout, document_page menu entries fit in any place, or create a new root in it. To assure compatibility with another document_* modules, you can put as XML-ID for this menu "base.menu_document" or similar, and declare the same menu in all modules that need it.

[naousse]

OK! Thanks, i will go that way

[dreispt]

@pedrobaeza But why create another module adding a new menu root when this module already does that? IMO it's not a problem to keep this, and document_pagecan depend on it for the creation of the top level menu.

[pedrobaeza]

No, you don't need another module, Daniel. You only need to declare the menu on subsequent modules. This is the way to implement it: https://github.com/OCA/knowledge/pull/76/files#diff-1b36a8a2d376367ab8f27aac507585a3R5

I also ask if current v9 menu layout can host menu entries for document_page and the rest of the document_* modules without creating a parent menu.

[max3903]

@pedrobaeza I tend to agree with @dreispt: we should declare the menuitem once in knowledge module instead of every submodules (document_page, document_*)

There is no menu_document in base.

[max3903]

@naousse Same remarks as described here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0#todo

and add Odoo Community Association (OCA) in the author keyword

[pedrobaeza]

OK, as you want. I was saying that for avoiding a dumb module. The technique I mention is used on Odoo for Sales, Purchases, and other top menus.

[max3903]

https://runbot.odoo-community.org/runbot/repo/118/9.0

[naousse]

I have made the corrections

[max3903]

👍

[dreispt]

Other than a couple of minor notes, it's 👍

[max3903]

This module is the base for any knowledge and document management application.

[max3903]

@naousse Please remove this line, it makes Travis failed.

[gurneyalex]

@max3903 are you sure of this?

[max3903]

@gurneyalex Not this one, but in __openerp__.py, it does.

[gurneyalex]

I'm surprised by the WARNINGs in runbot
https://runbot.odoo-community.org/runbot/build/3119551

[gurneyalex]

OCA/maintainer-quality-tools#295

[max3903]

👍