Skip to content

[18.0][MIG] product_lot_sequence: Migration to 18.0#2004

Merged
OCA-git-bot merged 53 commits intoOCA:18.0from
Kimkhoi3010:18.0-mig-product_lot_sequence
Jul 1, 2025
Merged

[18.0][MIG] product_lot_sequence: Migration to 18.0#2004
OCA-git-bot merged 53 commits intoOCA:18.0from
Kimkhoi3010:18.0-mig-product_lot_sequence

Conversation

@Kimkhoi3010
Copy link
Contributor

Change:

  • Since Odoo 18, company_id was computed since this commit, so i remove this check of the test test_lot_onchange_product_id_global:
    self.assertEqual(lot_form.company_id, self.env.company)

In v16:
image
In v18:
image

AdriaGForgeFlow and others added 30 commits June 24, 2025 11:55
[ADD] sequence for serials
Provide multiple configuration options with this module installed:

- "product": This is the default behaviour once you install this module. It's the
  same than in previous Odoo versions with this module installed, i.e. it allows
  to define a dedicated sequence on each product.

- "global": This was the default behaviour from previous Odoo versions when this
  module was not installed, i.e it will always use the same global sequence for every product.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-15.0/product-attribute-15.0-product_lot_sequence
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_lot_sequence/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-15.0/product-attribute-15.0-product_lot_sequence
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_lot_sequence/
…ews adjustment

- Make number of digits to be set on products for sequence generation configurable.
- Fix a minor issue of _compute_display_lot_sequence_fields() not running before
  product is created.
- Make lot_sequence_prefix and lot_sequence_padding invisible when lot_sequence_id
  is assigned to the product (since these values are no longer relevant once the
  sequence is generated.
<field name="inherit_id" ref="stock.view_template_property_form" />
<field name="arch" type="xml">
<field name="tracking" position="after">
<xpath expr="//field[@name='tracking']/.." position="after">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ensure we target the parent div element:

<xpath expr="//field[@name='tracking']/ancestor::div[1]" position="after">

@sebalix
Copy link
Contributor

sebalix commented Jul 1, 2025

/ocabot migration product_lot_sequence

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 1, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 1, 2025
71 tasks
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-product_lot_sequence branch from e9dfba4 to 4a975ce Compare July 1, 2025 08:03
@Kimkhoi3010 Kimkhoi3010 requested a review from sebalix July 1, 2025 08:03
Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@Highcooley Highcooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functionally

@sebalix
Copy link
Contributor

sebalix commented Jul 1, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-2004-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9930b8a into OCA:18.0 Jul 1, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 534c93c. Thanks a lot for contributing to OCA. ❤️

victoralmau pushed a commit to Tecnativa/product-attribute that referenced this pull request Jul 10, 2025
Signed-off-by sebalix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.