[FIX] mass_object view, remove fields of parent models from selection - #844
Closed
jbchouinard wants to merge 2 commits into
Closed
[FIX] mass_object view, remove fields of parent models from selection#844jbchouinard wants to merge 2 commits into
jbchouinard wants to merge 2 commits into
Conversation
|
On 10/community, I have a bug with product.template and taxes_id or supplier_taxes_id fields |
Member
|
JS tracebacks is useless if not in assets debugging mode. |
|
Thanks. Here's the traceback (debug=assets): |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
…spt-bump-patch Syncing from upstream OCA/server-tools (12.0-ocabot-merge-pr-2101-by-dreispt-bump-patch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comments on PR #820.
I am undoing erroneous commits, and fixing the mass object onchange.
As per comments on #820 it seems model_list/model_ids is no longer needed.
After testing on my end I do not see the need for it. The original intent seem to be add the fields from a parent model onto a mass_object record, but ir.model already has inherited fields on it.
For example: the field user_id is already listed on the res.users model, inherited from res.partner. There is no need to see the fields from res.partner when creating a mass_object for res.users.
@JayVora-SerpentCS does this seem right to you?