[16.0] [IMP] webservice: add support for oauth2 - #35
Merged
Conversation
Contributor
|
Hi @etobella, |
gurneyalex
force-pushed
the
16.0-webservice-oauth2
branch
3 times, most recently
from
March 4, 2024 18:03
618b2c3 to
6061dea
Compare
gurneyalex
marked this pull request as ready for review
March 4, 2024 18:21
simahawk
requested changes
Mar 5, 2024
gurneyalex
marked this pull request as draft
March 7, 2024 08:18
Member
Author
|
changing to draft: this implementation requests a new token for each api call, and some OAuth2 provider have an invoicing per token -> not acceptable. |
gurneyalex
force-pushed
the
16.0-webservice-oauth2
branch
from
March 12, 2024 11:03
4c6b99d to
990c972
Compare
gurneyalex
marked this pull request as ready for review
March 12, 2024 11:04
gurneyalex
force-pushed
the
16.0-webservice-oauth2
branch
from
March 12, 2024 12:48
372e70b to
dc970fd
Compare
simahawk
requested changes
Mar 15, 2024
gurneyalex
force-pushed
the
16.0-webservice-oauth2
branch
4 times, most recently
from
March 18, 2024 13:06
ae82a36 to
fc2accf
Compare
simahawk
reviewed
Mar 18, 2024
| responses.add(responses.GET, f"{self.url}endpoint", body="OK") | ||
|
|
||
| with mock_cursor(self.env.cr): | ||
| result = self.webservice.call("get", url=f"{self.url}endpoint") |
Contributor
There was a problem hiding this comment.
No need to test that commit has been called? Or that rollback is handled in case of errors?
Member
Author
gurneyalex
force-pushed
the
16.0-webservice-oauth2
branch
2 times, most recently
from
April 8, 2024 16:22
e7bf9a1 to
ee889c4
Compare
gurneyalex
force-pushed
the
16.0-webservice-oauth2
branch
from
April 9, 2024 08:51
ee889c4 to
1185d0f
Compare
gurneyalex
force-pushed
the
16.0-webservice-oauth2
branch
from
April 16, 2024 11:46
b20c9e0 to
4b5a907
Compare
Allow using oauth2 with Backend Application Flow / Client Credentials Grant.
gurneyalex
force-pushed
the
16.0-webservice-oauth2
branch
from
April 16, 2024 11:47
4b5a907 to
cfad24a
Compare
gurneyalex
changed the title
Member
Author
|
/ocabot merge minor |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 0524d1b. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.