[17.0][MIG] webservice: Migration to 17.0 by SilvioC2C · Pull Request #55 · OCA/web-api

SilvioC2C · 2024-07-11T11:43:22Z

Based on #34, includes #35 and #47 forwardport

john-herholz-dt · 2024-07-27T12:21:43Z

Thanks for taking over. Are you able to fix the tests? Should be not so complicated

imlopes · 2024-07-30T19:02:09Z

IMHO some errors are linked to OCA/OCB@4111f02
I've tried to fix, no success

john-herholz-dt · 2024-08-19T06:57:47Z

Hi there, I updated my PR for this as well but was struggling with the tests.
To mock the requests is really tricky. I stopped at the point in the tests where the responses object was checked.
When the request is mocked, the responses.calls were empty.

If anybody knows how to do this, please let us know.

 responses.add(responses.GET, self.url, body="{}")
 result = self.webservice.call("get")

Here the responses.calls will be empty

john-herholz-dt · 2024-08-19T19:49:09Z

@SilvioC2C congrats for the passed tests. Finally.
Have you been able to run tests locally. I always struggle to run OCA tests locally. Can you describe me how to set it up?
Just a demo database?

SilvioC2C · 2024-08-19T19:50:06Z

@john-herholz-dt @yankinmax @imlopes @gurneyalex tests are finally green, would you mind reviewing please? 🙏

SilvioC2C · 2024-08-19T19:55:07Z

Can you describe me how to set it up? Just a demo database?

Sorry, just saw your comment.
In C2C, we use a docker image that already contains test utils: https://github.com/camptocamp/docker-odoo-project#running-tests
Usually, I just run these commands:

docker-compose run --rm --name=odoo -e DB_NAME=testdb odoo testdb-gen -i <module_name>  # this creates a new DB and install the module I want to test
docker-compose run --rm --name=odoo -e DEMO=True -e DB_NAME=testdb -e MIGRATE=False odoo odoo --workers=0 --test-enable --stop-after-init -u <module_name>  # this updates the module and runs its tests

imlopes

Thanks for this huge work!!!

OCA-git-bot · 2024-08-19T20:33:55Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

yankinmax

I see where I was wrong, thanks @SilvioC2C very nice

john-herholz-dt · 2024-08-28T13:19:56Z

@simahawk can you merge it please? I saw you merged the migration to 16.0.
Thank you!

simahawk

Sorry, cannot be merged like this...
Issues:

commits are a bit messed up or incomplete
the mocking of the response seems useless as you should use responses

@SilvioC2C pls ping me and we can have a look together.

ivantodorovich · 2024-09-03T14:44:12Z

This PR includes:

[FIX] webservice: WARNING message in logs #47

However, that's not merged yet and by the looks of the reviewer's comments there's still some work to do there.
Could we take care of those comments and get approvals before attempting to forward port them here?

Alternatively, I'd suggest keeping the forward-port on a separate PR, so we can move on with the actual migration

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/

Currently translated at 100.0% (76 of 76 strings) Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/

The use of a compute method on ``oauth2_flow`` when this field is touched by the server environment mixin causes it to be defined twice as computed, with differents settings, and this ultimately causes a warning message in the logs: ``` WARNING odoo odoo.modules.registry: webservice.backend: inconsistent 'compute_sudo' for computed fields: protocol, url, auth_type, username, password, api_key, api_key_header, oauth2_flow, oauth2_clientid, oauth2_client_secret, oauth2_token_url, oauth2_authorization_url, oauth2_audience, oauth2_scope, content_type ``` We fix this by overriding method ``compute_server_env()``

SilvioC2C · 2024-09-17T19:11:47Z

@simahawk @ivantodorovich @imlopes @yankinmax @john-herholz-dt

I have reworked the PR to take care of the pending PR #47 (which has been superseded by #63, now merged) and the tests (but I'm still open to comments and suggestions).
I could use an helping hand about the commit history, though.

In the meanwhile, would you mind giving this PR another round of reviews? 😅

yankinmax

Thanks @SilvioC2C , I like your changes regarding tests.

simahawk · 2024-09-18T13:07:05Z

/ocabot migration webservice
/ocabot merge nobump

OCA-git-bot · 2024-09-18T13:07:13Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-55-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2024-09-18T13:10:45Z

Congratulations, your PR was merged at c8f979a. Thanks a lot for contributing to OCA. ❤️

imlopes reviewed Jul 30, 2024

View reviewed changes

Comment thread webservice/tests/common.py Outdated

imlopes reviewed Jul 30, 2024

View reviewed changes

Comment thread webservice/tests/common.py Outdated

yankinmax force-pushed the 17.0-mig-webservice branch 4 times, most recently from c47f5dd to 7f5236e Compare August 7, 2024 10:21

SilvioC2C force-pushed the 17.0-mig-webservice branch from 7f5236e to 8c1e734 Compare August 19, 2024 19:46

SilvioC2C requested a review from imlopes August 19, 2024 19:49

john-herholz-dt approved these changes Aug 19, 2024

View reviewed changes

imlopes approved these changes Aug 19, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Aug 19, 2024

yankinmax approved these changes Aug 20, 2024

View reviewed changes

simahawk requested changes Aug 29, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Aug 29, 2024

etobella and others added 5 commits September 17, 2024 18:23

[ADD] webservice

7931136

[UPD] Update webservice.pot

d042cfc

[UPD] README.rst

dc33d42

[MIG] webservice: Migration to 14.0

2f5a487

[UPD] Update webservice.pot

8053369

oca-ci and others added 7 commits September 17, 2024 18:23

[UPD] Update webservice.pot

1a4aa69

[BOT] post-merge updates

bf96745

Update translation files

a7cb36d

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/

Translated using Weblate (Italian)

3050fb9

Currently translated at 100.0% (76 of 76 strings) Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/

[BOT] post-merge updates

73a4fa5

[IMP] webservice: pre-commit auto fixes

c750c9d

SilvioC2C force-pushed the 17.0-mig-webservice branch from d6722d9 to a630501 Compare September 17, 2024 19:05

SilvioC2C added 2 commits September 17, 2024 21:09

[MIG] webservice: Migration to 17.0

6f28230

[IMP] webservice: improve tests

0398355

SilvioC2C force-pushed the 17.0-mig-webservice branch from a630501 to 0398355 Compare September 17, 2024 19:09

SilvioC2C requested review from imlopes, john-herholz-dt, simahawk and yankinmax September 17, 2024 19:15

john-herholz-dt approved these changes Sep 18, 2024

View reviewed changes

yankinmax approved these changes Sep 18, 2024

View reviewed changes

ivantodorovich approved these changes Sep 18, 2024

View reviewed changes

simahawk approved these changes Sep 18, 2024

View reviewed changes

OCA-git-bot added the approved label Sep 18, 2024

OCA-git-bot added this to the 17.0 milestone Sep 18, 2024

OCA-git-bot added the bot is merging ⏳ label Sep 18, 2024

OCA-git-bot mentioned this pull request Sep 18, 2024

Migration to version 17.0 #29

Open

4 tasks

OCA-git-bot merged commit 7174f50 into OCA:17.0 Sep 18, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 18, 2024

Uh oh!

Uh oh!

Conversation

SilvioC2C commented Jul 11, 2024

Uh oh!

john-herholz-dt commented Jul 27, 2024

Uh oh!

Uh oh!

Uh oh!

imlopes commented Jul 30, 2024

Uh oh!

john-herholz-dt commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

john-herholz-dt commented Aug 19, 2024

Uh oh!

SilvioC2C commented Aug 19, 2024

Uh oh!

SilvioC2C commented Aug 19, 2024

Uh oh!

imlopes left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Aug 19, 2024

Uh oh!

yankinmax left a comment

Choose a reason for hiding this comment

Uh oh!

john-herholz-dt commented Aug 28, 2024

Uh oh!

simahawk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivantodorovich commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SilvioC2C commented Sep 17, 2024

Uh oh!

yankinmax left a comment

Choose a reason for hiding this comment

Uh oh!

simahawk commented Sep 18, 2024

Uh oh!

OCA-git-bot commented Sep 18, 2024

Uh oh!

OCA-git-bot commented Sep 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

john-herholz-dt commented Aug 19, 2024 •

edited

Loading

simahawk left a comment •

edited

Loading

ivantodorovich commented Sep 3, 2024 •

edited

Loading