Show progress of upgrading the database schema. - #2
Merged
Conversation
This allows the logs folder to be opened if a command fails.
Historically, we've used ArgumentException to report command argument validation problems, and ignore the stack trace. If an "unexpected" ArgumentException is thrown, we lose all the stack trace information. We should actually use a special exception like ControlledFailureException to achieve the same result, and allow ArgumentExceptions from other places to flow unencumbered.
Recent changes means the home directory does not need to be configured separately to creating the instance.
3 tasks
jimmyp
added a commit
that referenced
this pull request
Jun 5, 2026
…hAbandon) + review fixes #1 Move abandon-support back onto the version (option A). The selector picks ScriptServiceVersion2WithAbandon when the Tentacle advertised AbandonScript, else ScriptServiceVersion2; the factory routes both to the V2 executor; the executor stamps the selected version onto the CommandContext, so the orchestrator gates on ScripServiceVersionUsed.SupportsAbandon. Reverts the CommandContext flag / capture-once / selector tuple. Capability string is nameof(IScriptServiceV2.AbandonScript) on both sides (server advertise + client check, unit fixture, integration test). Deleted the mocked selector unit test (redundant with the version approach). #2 CapabilitiesServiceV2Test: restore the count assertions (abandon-aware). #3 ClientScriptExecutionAbandon: capture each spawned PID and force-kill in TearDown so nothing leaks on CI. #4 SilentProcessRunnerFixture: add AbandonToken_WhenProcessCanNotBeKilled (asserts the process is still running, then cleans it up). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/OctopusDeploy/OctopusDeploy/pull/1126