Bug --noconsolelogging - #4
Merged
Merged
Conversation
Removing so they don't create doubt
| </targets> | ||
|
|
||
| <rules> | ||
| <logger name="SkipConsole" minlevel="Info" writeTo="octopus-log-file" /> |
Contributor
There was a problem hiding this comment.
What happened to these ones?
Contributor
Author
There was a problem hiding this comment.
That was an old way this feature was implemented back in the day, but I don't think it worked very well.
| <logger name="SkipConsole" minlevel="Info" writeTo="octopus-log-file" /> | ||
| <logger name="SkipConsole" minlevel="Fatal" writeTo="eventlog" final="true" /> | ||
|
|
||
| <logger name="*" minlevel="Info" maxLevel="Warn" writeTo="stdout" /> |
Contributor
There was a problem hiding this comment.
Bit concerned this might be a breaking change... Say someone is just redirecting stdout to a file - all of a sudden it doesn't log errors anymore.
Contributor
Author
There was a problem hiding this comment.
Yep, will update our 3.14 release notes and make it clear in the issue release note.
tothegills
approved these changes
Jun 14, 2017
tothegills
left a comment
tothegills
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, nothing is jumping out at me screaming "this will break the world"
3 tasks
jimmyp
added a commit
that referenced
this pull request
Jun 5, 2026
…hAbandon) + review fixes #1 Move abandon-support back onto the version (option A). The selector picks ScriptServiceVersion2WithAbandon when the Tentacle advertised AbandonScript, else ScriptServiceVersion2; the factory routes both to the V2 executor; the executor stamps the selected version onto the CommandContext, so the orchestrator gates on ScripServiceVersionUsed.SupportsAbandon. Reverts the CommandContext flag / capture-once / selector tuple. Capability string is nameof(IScriptServiceV2.AbandonScript) on both sides (server advertise + client check, unit fixture, integration test). Deleted the mocked selector unit test (redundant with the version approach). #2 CapabilitiesServiceV2Test: restore the count assertions (abandon-aware). #3 ClientScriptExecutionAbandon: capture each spawned PID and force-kill in TearDown so nothing leaks on CI. #4 SilentProcessRunnerFixture: add AbandonToken_WhenProcessCanNotBeKilled (asserts the process is still running, then cleans it up). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7