bin/ci: pass POSTGRES_HOST_AUTH_METHOD=trust to postgres container - #20
Closed
danp wants to merge 3 commits into
Closed
bin/ci: pass POSTGRES_HOST_AUTH_METHOD=trust to postgres container#20danp wants to merge 3 commits into
danp wants to merge 3 commits into
Conversation
In docker-library/postgres#658 a change was made to the postgres image to require a password by default or explicit disabling of auth. For bin/ci, disable auth to keep configs simple. Add a note reminding that doing this is highly insecure and should not be done in production.
Contributor
Author
|
This does not fully fix CI but it does get further, running the app but failing with: |
Member
|
Thanks for working on this @danp! The remaining problem looks very similar to these issue:
Maybe just adding a bean for Like: You might need one for |
Member
|
Oh, see this example too, which has commented out config for these classes: <!--
<jee:jndi-lookup id="xwikiUrlBean" jndi-name="java:comp/env/xwikiUrl" resource-ref="true" ></jee:jndi-lookup>
<jee:jndi-lookup id="xwikiDocumentEditUrlBean" jndi-name="java:comp/env/wikiDocumentEditUrl" resource-ref="true" ></jee:jndi-lookup>
<jee:jndi-lookup id="xwikiAttachmentUrlBean" jndi-name="java:comp/env/wikiAttachmentUrl" resource-ref="true" ></jee:jndi-lookup>
<bean id="wikiDocumentService" class="org.onebusaway.wiki.xwiki.impl.XWikiDocumentServiceImpl" lazy-init="true">
<property name="xwikiUrl" ref="xwikiUrlBean" />
</bean>
<bean id="wikiRenderingService" class="org.onebusaway.wiki.xwiki.impl.XWikiRenderingServiceImpl" lazy-init="true">
<property name="wikiDocumentViewUrl" value="/wiki/%{documentName}" />
<property name="wikiDocumentEditUrl" ref="xwikiDocumentEditUrlBean" />
<property name="wikiAttachmentUrl" ref="xwikiAttachmentUrlBean" />
</bean>
--> |
Contributor
Author
|
Based on https://github.com/OneBusAway/onebusaway-wiki-integration/blob/master/onebusaway-wiki-integration-simple/src/main/java/org/onebusaway/wiki/simple/SimpleWikiDocumentServiceImpl.java existing, I tired: <bean id="wikiDocumentService" class="org.onebusaway.wiki.simple.SimpleWikiDocumentServiceImpl" />
<bean id="wikiRenderingService" class="org.onebusaway.wiki.simple.SimpleWikiRenderingServiceImpl" />But that errors with: Is there some way to disable wiki integration? |
Member
|
@danp I don't think that's the right wiki impl class, as it was last edited years ago. Did you try the config in #20 (comment)? |
Contributor
Author
|
Ah, blast. I did try with |
Member
|
Yeah, we don't want to have to run Xwiki. IIRC as long as you give it a valid host name, even if it 404s on the actual links, it will work. |
Contributor
Author
|
Based on the example and things at https://github.com/OneBusAway/onebusaway/wiki/Wiki-Integration#xwiki-configuration-for-onebusaway-webapp, just push up what I tried. It failed with: |
Member
|
@danp I believe that wiki page on configuration the wiki is really old too and relates to OBA v1.x. This page is new for v2.x: ...but doesn't mention xwiki. I'll try to look at the newest error you posted tomorrow. |
Member
|
@danp Sorry, way late on this, but for that error did you try adding: <bean id="agencyMetadataSessionFactory" class="org.springframework.orm.hibernate3.annotation.AnnotationSessionFactoryBean">
<property name="dataSource" ref="agencyMetadataDataSource" />
<property name="annotatedClasses">
<list>
<value>org.onebusaway.agency_metadata.model.AgencyMetadata</value>
<value>org.onebusaway.agency_metadata.service.AgencyMetadataDaoImpl</value>
</list>
</property>
<property name="hibernateProperties">
<props>
<prop key="hibernate.connection.pool_size">1</prop>
<prop key="hibernate.current_session_context_class">thread</prop>
<prop key="hibernate.cache.provider_class">org.hibernate.cache.NoCacheProvider</prop>
</props>
</property>
</bean>This is from the config at https://github.com/OneBusAway/onebusaway-application-modules/wiki/Enterprise-Webapp-Configuration, which should (hopefully) work for v2.x. |
danp
force-pushed
the
fix-bin-ci-postgres
branch
from
July 30, 2020 22:13
3da57ea to
0360de0
Compare
Contributor
Author
|
Tried that just now, sorry for the delay. Didn't pass but I didn't dig into why. Not sure I can help any more here. |
Member
|
There are some tips here that appeared to work for someone that we can try: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In docker-library/postgres#658 a change was
made to the postgres image to require a password by default or
explicit disabling of auth.
For bin/ci, disable auth to keep configs simple. Add a note reminding
that doing this is highly insecure and should not be done in production.
Updates #19