Skip to content

add enterprise-acta-webapp - #7

Merged
danp merged 3 commits into
OneBusAway:masterfrom
danp:enterprise-acta
Mar 7, 2018
Merged

add enterprise-acta-webapp#7
danp merged 3 commits into
OneBusAway:masterfrom
danp:enterprise-acta

Conversation

@danp

@danp danp commented Jan 28, 2018

Copy link
Copy Markdown
Contributor

Adds onebusaway-enterprise-acta-webapp (i.e., v2 of the web UI) to the mix.

For deployments of v2 interface see:

Some configuration instructions:
https://github.com/OneBusAway/onebusaway-application-modules/wiki/Enterprise-Webapp-Configuration

@danp

danp commented Jan 28, 2018

Copy link
Copy Markdown
Contributor Author

Doesn't currently work due to bean config issue but I'm having trouble figuring out what's missing.

@danp danp added this to the Phase 2: Also works with PostgreSQL milestone Jan 28, 2018
@danp

danp commented Jan 28, 2018

Copy link
Copy Markdown
Contributor Author

Currently failing in travis here with:

 org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'searchServiceImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private org.onebusaway.geocoder.enterprise.services.EnterpriseGeocoderService org.onebusaway.presentation.impl.search.SearchServiceImpl._geocoderService; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No matching bean of type [org.onebusaway.geocoder.enterprise.services.EnterpriseGeocoderService] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)}

@barbeau

barbeau commented Jan 28, 2018

Copy link
Copy Markdown
Member

I believe this means you're missing an entry for searchServiceImplin data-sources, but this is new in v2, so I don't know what it's supposed to contain.

@danp

danp commented Feb 3, 2018

Copy link
Copy Markdown
Contributor Author

Did some digging but wasn't able to find any examples to build on. Maybe @sheldonabrown could offer a hint?

@sheldonabrown

Copy link
Copy Markdown
Member

You missed two beans in the config instructions: "externalGeocoderImpl" and "serviceAreaServiceImpl". Scroll to the last snippet.

https://github.com/OneBusAway/onebusaway-application-modules/wiki/Enterprise-Webapp-Configuration

They can both be empty beans to get started, but do need to be present.

@danp

danp commented Feb 28, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!

Hmm, the config added by this PR already has both externalGeocoderImpl and serviceAreaServiceImpl entries, pretty sure I copied the config at the bottom of https://github.com/OneBusAway/onebusaway-application-modules/wiki/Enterprise-Webapp-Configuration to get started.

Should one of those be creating the searchServiceImpl bean that error messages mention?

@danp

danp commented Mar 7, 2018

Copy link
Copy Markdown
Contributor Author

Got this green!

However, it probably only does the bare minimum to load the UI. Visiting a route page doesn't properly load the Google Map, for example, since there are no API keys. That will follow!

@danp
danp merged commit dcc36d7 into OneBusAway:master Mar 7, 2018
@danp
danp deleted the enterprise-acta branch March 7, 2018 23:31
@danp danp mentioned this pull request Mar 7, 2018
@barbeau

barbeau commented Mar 7, 2018

Copy link
Copy Markdown
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants