fix(windows): ASR final result 等待加超时保护#120
Merged
appergb merged 1 commit intoMay 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Sorry @Cooper-X-Oak, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Collaborator
|
@codex review |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97
修复要点
Windows 端结束录音后,Volcengine ASR 发送 last frame 之后会等待服务端 final result。此前这一步没有 deadline:如果服务端没有返回 final frame、但连接也没有立即断开,coordinator 会一直卡在
Transcribing。本 PR 给 final result 等待增加明确超时保护:
FinalResultTimeout错误,而不是无限 await。测试计划
npm run buildcargo +stable-x86_64-pc-windows-gnu test --manifest-path openless-all\app\src-tauri\Cargo.toml --target x86_64-pc-windows-gnu asr::volcengine::tests::await_final_result_returns_error_when_final_frame_never_arrives --no-rungit diff --check备注
本机 GNU 测试二进制在运行阶段遇到
STATUS_ENTRYPOINT_NOT_FOUND,但测试目标已完成编译;因此本地使用--no-run作为 Rust 编译门禁,并由 GitHub Windows CI 补足平台检查。