Skip to content

Fix Zhipu ASR endpoint handling#510

Merged
H-Chris233 merged 1 commit into
Open-Less:betafrom
H-Chris233:issue-507-zhipu-asr-url-error-ui
May 20, 2026
Merged

Fix Zhipu ASR endpoint handling#510
H-Chris233 merged 1 commit into
Open-Less:betafrom
H-Chris233:issue-507-zhipu-asr-url-error-ui

Conversation

@H-Chris233
Copy link
Copy Markdown
Collaborator

@H-Chris233 H-Chris233 commented May 20, 2026

User description

Summary

  • Refs zhipu ASR: 404 due to doubled API path + errors invisible in app UI #507.
  • Normalize Whisper/Zhipu ASR transcription URLs so /v4, /v4/audio, and full /v4/audio/transcriptions endpoints all post to the correct endpoint without doubling the path.
  • Preserve query parameters on custom transcription endpoints.
  • Fix a macOS CI-only test-server race by returning accepted test sockets to blocking mode before reading the multipart request.

Not Included

  • This PR intentionally does not change Linux ASR error visibility/UI behavior.

Test Plan

  • cargo test --manifest-path \"/home/chris233/openless/openless-all/app/src-tauri/Cargo.toml\" transcription_url_accepts_base_audio_or_full_endpoint -- --test-threads=1
  • cargo test --manifest-path \"/home/chris233/openless/openless-all/app/src-tauri/Cargo.toml\" asr::whisper::tests::transcribe_posts_single_request_without_chunk_limit -- --test-threads=1
  • git diff --check upstream/beta

Review

  • Subagent review: APPROVE

PR Type

Bug fix, Tests


Description

  • Normalize Zhipu ASR transcription URLs

  • Avoid doubled /audio/transcriptions paths

  • Preserve query strings on custom endpoints

  • Fix macOS ASR test socket blocking


Diagram Walkthrough

flowchart LR
  A["ASR base URL"] -- "normalize" --> B["transcription_url()"]
  B -- "used by" --> C["Whisper transcription request"]
  B -- "verified by" --> D["URL normalization tests"]
  E["Accepted test socket"] -- "set blocking" --> F["Multipart request reader"]
Loading

File Walkthrough

Relevant files
Bug fix
whisper.rs
Normalize ASR URLs and strengthen tests                                   

openless-all/app/src-tauri/src/asr/whisper.rs

  • Replaces manual URL concatenation with transcription_url()
  • Prevents duplicated /audio/transcriptions for Zhipu endpoints
  • Preserves query parameters when rebuilding transcription URLs
  • Adds regression coverage and fixes test socket blocking
+42/-2   

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

PR Reviewer Guide 🔍

(Review updated until commit 7b39491)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

507 - Partially compliant

Compliant requirements:

  • Prevent doubled /audio/transcriptions paths.
  • Accept the transcription endpoint forms and preserve query parameters.

Non-compliant requirements:

  • Surface transcription failures in the app UI.

Requires further human verification:

  • None
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@H-Chris233 H-Chris233 force-pushed the issue-507-zhipu-asr-url-error-ui branch from 400ff6b to 7b39491 Compare May 20, 2026 12:56
@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit 7b39491

@H-Chris233 H-Chris233 merged commit 482984a into Open-Less:beta May 20, 2026
4 checks passed
appergb pushed a commit that referenced this pull request May 22, 2026
…s/Linux 修复

自 v1.3.4-11-beta-tauri 以来的改动:

- feat(ui): 给划词追问框与语音胶囊加磨砂玻璃质感(#519)
- fix(linux): 修复 Linux 主窗口控件(#518 / issue #517)
- fix(windows): 缩短 Windows IME 提交超时(#514 / issue #491)
- fix(windows): 流式 SendInput 节流(#513 / issue #491)
- feat(asr): 新增更大的 Foundry Whisper 模型(#512 / issue #511)
- fix(asr): 修复智谱 ASR endpoint 处理(#510 / issue #507)
- fix(ui+network): 更新/登录/网络检测/市场加载四项修复
- fix(asr): 修复智谱批量 ASR 分片(#509 / issue #508)

本次只动版本号,逻辑改动已在上述 PR 落盘。

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant