Bugfix/activate helidon versionutil tests#18815
Merged
wing328 merged 3 commits intoJun 2, 2024
Merged
Conversation
Philzen
force-pushed
the
bugfix/activate-helidon-versionutil-tests
branch
from
June 1, 2024 00:55
bc9d8a4 to
df0e3de
Compare
Contrary to Junit5, classes containing TestNG tests need to have public visibility, otherwise the tests will not be discovered and run.
Philzen
force-pushed
the
bugfix/activate-helidon-versionutil-tests
branch
from
June 2, 2024 10:35
df0e3de to
ad3e000
Compare
Contributor
Author
|
@wing328 Rebased and ready to merge |
welshm
pushed a commit
to welshm/openapi-generator
that referenced
this pull request
Jun 5, 2024
* Reactivate tests Contrary to Junit5, classes containing TestNG tests need to have public visibility, otherwise the tests will not be discovered and run. * Reformat tests for readability * Rewrite tests using fluent assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrary to Junit5, classes containing TestNG tests need to have public visibility, otherwise the tests will not be discovered and run.
This PR fixes the visibility and refactors the test code for readability. Adds to #18627
@tjquinno
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)