Skip to content

Bugfix/activate helidon versionutil tests #18815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 3 commits into from
Jun 2, 2024
Merged

Bugfix/activate helidon versionutil tests #18815

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1e1897
Reactivate tests
Philzen Jun 1, 2024
2dbbbb6
Reformat tests for readability
Philzen Jun 1, 2024
ad3e000
Rewrite tests using fluent assertions
Philzen Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 12 additions & 23 deletions ...-generator/src/test/java/org/openapitools/codegen/languages/HelidonCommonCodegenTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,37 +16,26 @@
*/
package org.openapitools.codegen.languages;

import org.testng.annotations.Test;

import java.util.List;

import org.testng.Assert;
import org.testng.annotations.Test;
import static org.assertj.core.api.Assertions.assertThat;

// This test class is in this package, not org.openapitools.codegen.java.helidon, so it can refer to elements of
// JavaHelidonCommonCodegen without making them public; package-private is sufficient and we don't want to expose those methods
// more broadly.
class HelidonCommonCodegenTest {
public class HelidonCommonCodegenTest {

@Test
void checkMajorVersionMatch() {
Assert.assertEquals("1.2.3",
JavaHelidonCommonCodegen.VersionUtil.instance().chooseVersion("1",
List.of("3.2.1",
"3.2.0",
"2.0.4",
"1.2.3",
"1.2.2",
"1.1.0")));
JavaHelidonCommonCodegen.VersionUtil test = JavaHelidonCommonCodegen.VersionUtil.instance();

@Test void checkMajorVersionMatch() {
assertThat(test.chooseVersion("1", List.of("3.2.1", "3.2.0", "2.0.4", "1.2.3", "1.2.2", "1.1.0")))
.isEqualTo("1.2.3");
}

@Test
void checkExactMatch() {
Assert.assertEquals("1.2.2",
JavaHelidonCommonCodegen.VersionUtil.instance().chooseVersion("1.2.2",
List.of("3.2.1",
"3.2.0",
"2.0.4",
"1.2.3",
"1.2.2",
"1.1.0")));
@Test void checkExactMatch() {
assertThat(test.chooseVersion("1.2.2", List.of("3.2.1", "3.2.0", "2.0.4", "1.2.3", "1.2.2", "1.1.0")))
.isEqualTo("1.2.2");
}
}