Skip to content

[Dart] Better logging#9090

Merged
wing328 merged 1 commit into
masterfrom
dart-improve
Mar 26, 2021
Merged

[Dart] Better logging#9090
wing328 merged 1 commit into
masterfrom
dart-improve

Conversation

@wing328

@wing328 wing328 commented Mar 26, 2021

Copy link
Copy Markdown
Member

Better logging to avoid string concatenation

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

@wing328 wing328 added Client: Dart Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Mar 26, 2021
@wing328 wing328 added this to the 5.1.1 milestone Mar 26, 2021
@wing328 wing328 merged commit 8542966 into master Mar 26, 2021
@wing328 wing328 deleted the dart-improve branch March 26, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Dart Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants