[Javascript-Flowtyped] Handle joining uniqueItems in api template#9412
Closed
kkellyy wants to merge 18 commits into
Closed
[Javascript-Flowtyped] Handle joining uniqueItems in api template#9412kkellyy wants to merge 18 commits into
kkellyy wants to merge 18 commits into
Conversation
* nim petstore to use 3.0 spec * ktorm to use 3.0 spec * update c petstore to use 3.0 spec * Revert "update c petstore to use 3.0 spec" This reverts commit a8ff051.
…ls#9321) * generation type on template dir path * remove gen_type from template and resources
…PITools#8624) * [scala][akka] Update dependencies for scala 2.13 * Update pom.mustache to support multiple scala's version * Update pom.xml * Scala cross build 2.12 and 2.13 * Update version. Migrate to sbt * Remove space * Add pom.xml back
…penAPITools#9271) * Avoid DeprecationWarning in inspect.getargspec on Python 3 * Regenerate samples
* [TypeScript] Fix misplaced parentheses * [TypeScript] Run PR relevant scripts * [TypeScript] ensure up to date * Revert "[TypeScript] ensure up to date" This reverts commit 320ec45 * Revert "[TypeScript] Run PR relevant scripts" This reverts commit 23cda75 Co-authored-by: Stefan Wendt <stefan.wendt@isax.com>
…te attribute (OpenAPITools#9373) * Removed obsolete attribute on constructors without HttpClient prameter * add clickable link in the tooltip * update doc, add tests Co-authored-by: William Cheng <wing328hk@gmail.com>
* Add VMware to users list LMK if I can provide the png for company logo. I tried uploading to img folder and could not. * add logo, update readme Co-authored-by: William Cheng <wing328hk@gmail.com>
* overhaul pistache templates * fix function signature in model-source return type now aligns with definition in model-header * use default keyword for destructors * generate pistache samples * move bin/configs/other/cpp-pistache-server-cpp-pistache.yaml to bin/configs/cpp-pistache-server-cpp-pistache.yaml * Only generate validation body if necessary * generate pistache samples
kkellyy
changed the title
* test erlang client, server in drone.io * rearrange tests, add server folder * comment out erlang server tests
* fix incorrect aspnetcore logging messages * address comments from review cleans up log messages
Member
|
@kkellyy thanks for the PR. I saw you targeted this change to the 5.2.x branch (breaking changes with fallback). Is this PR more like a bug fix? |
…nAPITools#9382) * Revert "[cpp-ue4] Added the possibility to retry requests easily with AsyncRetry method on the response and SetAutoRetryCount on the request" * [cpp-ue4] Improved retry system to use Unreal's FHttpRetrySystem * [cpp-ue4] Updated style guide link * update samples Co-authored-by: William Cheng <wing328hk@gmail.com>
Contributor
Author
Oh yeah, good call. wasn't 100% sure, but it's more a bug fix |
kkellyy
force-pushed
the
js_flowtyped_handle_uniqueitems
branch
from
d6aa450 to
cde6976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these changes, openapi-generator will create
Set()objects for swagger parameters with"uniqueItems": true. This wraps thoseSets inArray.from()so they can be properly joined. When debugging this in our setup, I found #8695 which fixes this issue fortypescript-fetchin the same way.Also replaced some mixed-indent with spaces in the relevant file.