Skip to content

[backend] handle decay excluded indicators in indicatorEditField (#14347)#14572

Merged
JeremyCloarec merged 1 commit intomasterfrom
issue/14347
Feb 25, 2026
Merged

[backend] handle decay excluded indicators in indicatorEditField (#14347)#14572
JeremyCloarec merged 1 commit intomasterfrom
issue/14347

Conversation

@JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Feb 24, 2026

Proposed changes

  • indicatorEditField has a lot of buisness logic for handling updates on indicators impacted by decay. When a decay exclusion rule is applied, user should be able to update the indicator as he wants instead

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Feb 24, 2026
@JeremyCloarec JeremyCloarec marked this pull request as ready for review February 24, 2026 09:34
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 30.89%. Comparing base (0edbff5) to head (c9c8f92).
⚠️ Report is 207 commits behind head on master.

Files with missing lines Patch % Lines
...-graphql/src/modules/indicator/indicator-domain.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14572      +/-   ##
==========================================
- Coverage   32.10%   30.89%   -1.21%     
==========================================
  Files        3010     3136     +126     
  Lines      206753   238564   +31811     
  Branches    37736    50341   +12605     
==========================================
+ Hits        66368    73703    +7335     
- Misses     140385   164861   +24476     
Flag Coverage Δ
opencti-client-python 44.44% <ø> (-1.09%) ⬇️
opencti-front 3.11% <ø> (+0.57%) ⬆️
opencti-graphql 69.37% <75.00%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeremyCloarec JeremyCloarec merged commit 100bce5 into master Feb 25, 2026
37 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/14347 branch February 25, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decay Exclusion Rule: Cannot update a score manually

2 participants