[frontend] Investigation: Expand knowledge popup: incorrect margins/rendering (#14707)#14726
Merged
Gwendoline-FAVRE-FELIX merged 2 commits intomasterfrom Mar 6, 2026
Merged
[frontend] Investigation: Expand knowledge popup: incorrect margins/rendering (#14707)#14726Gwendoline-FAVRE-FELIX merged 2 commits intomasterfrom
Gwendoline-FAVRE-FELIX merged 2 commits intomasterfrom
Conversation
Gwendoline-FAVRE-FELIX
added
the
filigran team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14726 +/- ##
==========================================
- Coverage 32.37% 32.34% -0.04%
==========================================
Files 3098 3098
Lines 211068 213306 +2238
Branches 38242 38516 +274
==========================================
+ Hits 68343 69003 +660
- Misses 142725 144303 +1578
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Archidoit
approved these changes
Mar 6, 2026
| <FormLabel component="legend">{label}</FormLabel> | ||
|
|
||
| <ButtonGroup size="small" sx={{ marginY: 1 }}> | ||
| <ButtonGroup size="small" sx={{ marginY: 1.5 }}> |
Member
There was a problem hiding this comment.
we usually don't accept margin with a dot (only entire number)... but if REALLY needed let's keep that :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues