Skip to content

[frontend] Investigation: Expand knowledge popup: incorrect margins/rendering (#14707) #14726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gwendoline-FAVRE-FELIX merged 2 commits into from
Mar 6, 2026
Merged

[frontend] Investigation: Expand knowledge popup: incorrect margins/rendering (#14707) #14726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43cfe98
[frontend] Fix margins (#14707)
Gwendoline-FAVRE-FELIX Mar 3, 2026
72d02ce
[frontend] Fix margins (#14707)
Gwendoline-FAVRE-FELIX Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opencti-platform/opencti-front/src/components/CheckboxesField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const CheckboxesField = ({
<FormControl component="fieldset" name={name}>
<FormLabel component="legend">{label}</FormLabel>

<ButtonGroup size="small" sx={{ marginY: 1 }}>
<ButtonGroup size="small" sx={{ marginY: 1.5 }}>
Copy link
Member

@Archidoit Archidoit Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually don't accept margin with a dot (only entire number)... but if REALLY needed let's keep that :/

<Button
disabled={items.length === 0}
variant={(items.length > 0 && value.length === items.length) ? 'primary' : 'secondary'}
Expand Down
4 changes: 2 additions & 2 deletions opencti-platform/opencti-front/src/components/graph/components/GraphToolbarExpandTools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,9 +665,9 @@ const GraphToolbarExpandTools = ({

<Dialog
fullWidth
maxWidth="sm"
maxWidth={false}
open={isExpandOpen}
slotProps={{ paper: { elevation: 1 } }}
sx={{ '& .MuiDialog-paper': { width: 640 } }}
onClose={() => setIsExpandOpen(false)}
>
<InvestigationExpandForm
Expand Down
64 changes: 33 additions & 31 deletions ...pencti-front/src/private/components/workspaces/investigations/InvestigationExpandForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,40 +371,42 @@ const InvestigationExpandFormContent = ({
>
{({ submitForm, handleReset, isSubmitting }) => (
<Form>
<Stack direction="row" justifyContent="space-between">
<Field
name="entity_types"
component={CheckboxesField}
label={t_i18n('All types of target')}
items={targets}
/>
<Stack spacing={3} sx={{ p: 3 }}>
<Stack direction="row" justifyContent="space-between">
<Field
name="entity_types"
component={CheckboxesField}
label={t_i18n('All types of target')}
items={targets}
/>
<Field
name="relationship_types"
component={CheckboxesField}
label={t_i18n('All types of relationship')}
items={relationships}
/>
</Stack>

<Field
name="relationship_types"
component={CheckboxesField}
label={t_i18n('All types of relationship')}
items={relationships}
component={SwitchField}
type="checkbox"
name="reset_filters"
label={t_i18n('Reset filters')}
containerstyle={{ marginTop: 12 }}
/>
</Stack>

<Field
component={SwitchField}
type="checkbox"
name="reset_filters"
label={t_i18n('Reset filters')}
containerstyle={{ marginTop: 20 }}
/>

<DialogActions>
<Button variant="secondary" onClick={handleReset} disabled={isSubmitting}>
{t_i18n('Cancel')}
</Button>
<Button
onClick={submitForm}
disabled={isSubmitting}
>
{t_i18n('Expand')}
</Button>
</DialogActions>
<DialogActions>
<Button variant="secondary" onClick={handleReset} disabled={isSubmitting}>
{t_i18n('Cancel')}
</Button>
<Button
onClick={submitForm}
disabled={isSubmitting}
>
{t_i18n('Expand')}
</Button>
</DialogActions>
</Stack>
</Form>
)}
</Formik>
Expand Down